Edge test cases for 24 to 12 hours formatting functions

Author: russom

Project-CLI-Treasure-Hunt

@@ -0,0 +1 @@
+Subproject commit 3e66462a26c1d68cc2ac562b0d3ad7b3c2210fa1

Sprint-2/5-stretch-extend/format-time.js

@@ -4,69 +4,82 @@
 
 function formatAs12HourClock(time) {
   const hours = Number(time.slice(0, 2));
+
   if (hours > 12) {
     return `${hours - 12}:00 pm`;
   } else if (hours === 12) {
     return `${hours}:00 pm`;
   } else if (hours === 0) {
     return `12:00 am`;
-  } else if (hours < 12) {
+  } else {
     return `${time} am`;
-  } else return `${time} am`;
-}
+  }
+
+  const currentOutput = formatAs12HourClock("08:00");
+  const targetOutput = "08:00 am";
+  console.assert(
+    currentOutput === targetOutput,
+    `current output: ${currentOutput}, target output: ${targetOutput}`
+  );
 
-const currentOutput = formatAs12HourClock("08:00");
-const targetOutput = "08:00 am";
-console.assert(
-  currentOutput === targetOutput,
-  `current output: ${currentOutput}, target output: ${targetOutput}`
-);
+  const currentOutput2 = formatAs12HourClock("23:00");
+  const targetOutput2 = "11:00 pm";
+  console.assert(
+    currentOutput2 === targetOutput2,
+    `current output: ${currentOutput2}, target output: ${targetOutput2}`
+  );
 
-const currentOutput2 = formatAs12HourClock("23:00");
-const targetOutput2 = "11:00 pm";
-console.assert(
-  currentOutput2 === targetOutput2,
-  `current output: ${currentOutput2}, target output: ${targetOutput2}`
-);
+  const currentOutput3 = formatAs12HourClock("00:00");
+  const targetOutput3 = "12:00 am";
+  console.assert(
+    currentOutput3 === targetOutput3,
+    `current output: ${currentOutput3}, target output: ${targetOutput3}`
+  );
 
-const currentOutput3 = formatAs12HourClock("00:00");
-const targetOutput3 = "12:00 am";
-console.assert(
-  currentOutput3 === targetOutput3,
-  `current output: ${currentOutput3}, target output: ${targetOutput3}`
-);
+  const currentOutput4 = formatAs12HourClock("12:00");
+  const targetOutput4 = "12:00 pm";
+  console.assert(
+    currentOutput4 === targetOutput4,
+    `current output: ${currentOutput4}, target output: ${targetOutput4}`
+  );
 
-const currentOutput4 = formatAs12HourClock("12:00");
-const targetOutput4 = "12:00 pm";
-console.assert(
-  currentOutput4 === targetOutput4,
-  `current output: ${currentOutput4}, target output: ${targetOutput4}`
-);
+  const currentOutput5 = formatAs12HourClock("00:01");
+  const targetOutput5 = "12:01 am";
+  console.assert(
+    currentOutput5 === targetOutput5,
+    `current output: ${currentOutput5}, target output: ${targetOutput5}`
+  );
 
-const currentOutput5 = formatAs12HourClock("00:01");
-const targetOutput5 = "12:01 am";
-console.assert(
-  currentOutput5 === targetOutput5,
-  `current output: ${currentOutput5}, target output: ${targetOutput5}`
-);
+  const currentOutput6 = formatAs12HourClock("12:01");
+  const targetOutput6 = "12:01 pm";
+  console.assert(
+    currentOutput6 === targetOutput6,
+    `current output: ${currentOutput6}, target output: ${targetOutput6}`
+  );
+
+  const currentOutput7 = formatAs12HourClock("23:59");
+  const targetOutput7 = "11:59 pm";
+  console.assert(
+    currentOutput7 === targetOutput7,
+    `current output: ${currentOutput7}, target output: ${targetOutput7}`
+  );
+
+  const currentOutput8 = formatAs12HourClock("13:00");
+  const targetOutput8 = "01:00 pm";
+  console.assert(
+    currentOutput8 === targetOutput8,
+    `current output: ${currentOutput8}, target output: ${targetOutput8}`
+  );
+}
 
-const currentOutput6 = formatAs12HourClock("12:01");
-const targetOutput6 = "12:01 pm";
-console.assert(
-  currentOutput6 === targetOutput6,
-  `current output: ${currentOutput6}, target output: ${targetOutput6}`
-);
+// Edge test cases that should be tested:
 
-const currentOutput7 = formatAs12HourClock("23:59");
-const targetOutput7 = "11:59 pm";
-console.assert(
-  currentOutput7 === targetOutput7,
-  `current output: ${currentOutput7}, target output: ${targetOutput7}`
-);
+// 1) 08:00 -> 08:00 am
+// 2) 23:00 -> 11:00 PM
+// 3) 00:00 -> 12:00 AM
+// 5) 12:00 -> 12:00 PM
+// 6) 00:01 -> 12:01 AM
+// 7) 12:01 -> 12:01 PM
+// 8) 23:59 -> 11:59 PM
+// 9) 13:00 -> 1:00 PM
 
-const currentOutput8 = formatAs12HourClock("13:00");
-const targetOutput8 = "01:00 pm";
-console.assert(
-  currentOutput8 === targetOutput8,
-  `current output: ${currentOutput8}, target output: ${targetOutput8}`
-);