Finished last part 1 the first section of Sprint-3 /1-implement-and-rewrite-tests.

Author: Jacknguyen4438

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -12,6 +12,11 @@
 
 function isProperFraction(numerator, denominator) {
   // TODO: Implement this function
+ if ( numerator > 0 && denominator > 0 && denominator !==0 && numerator < denominator){
+  return true;
+ } else {
+  return false
+ }
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.
@@ -31,3 +36,9 @@ function assertEquals(actualOutput, targetOutput) {
 
 // Example: 1/2 is a proper fraction
 assertEquals(isProperFraction(1, 2), true);
+assertEquals(isProperFraction("2", 2), false);
+assertEquals(isProperFraction(3, 4), true);
+assertEquals(isProperFraction(5, 10), true);
+assertEquals(isProperFraction(- 4, 2), false);
+assertEquals(isProperFraction(- 4, 10), false);
+assertEquals(isProperFraction(123123213n, 0), false);

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -23,8 +23,44 @@
 
 function getCardValue(card) {
   // TODO: Implement this function
+  const cardRanks = [
+    "A",
+    "2",
+    "3",
+    "4",
+    "5",
+    "6",
+    "7",
+    "8",
+    "9",
+    "10",
+    "J",
+    "Q",
+    "K",
+  ];
+  const cardSuits = ["♠", "♥", "♦", "♣"];
+  if (
+    typeof card !== "string" ||
+    !cardRanks.includes(card.slice(0,-1)) ||
+    !cardSuits.includes(card.slice(-1))
+  ) {
+    throw new Error("Invalid card");
+  }
+
+  switch (card.slice(0, -1)) {
+    case "A":
+      return 11;
+    case "J":
+    case "Q":
+    case "K":
+      return 10;
+    default:
+      return Number(card.slice(0, -1));
+  }
 }
 
+
+
 // The line below allows us to load the getCardValue function into tests in other files.
 // This will be useful in the "rewrite tests with jest" step.
 module.exports = getCardValue;
@@ -40,13 +76,28 @@ function assertEquals(actualOutput, targetOutput) {
 // TODO: Write tests to cover all outcomes, including throwing errors for invalid cards.
 // Examples:
 assertEquals(getCardValue("9♠"), 9);
+assertEquals(getCardValue("A♥"), 11);
+assertEquals(getCardValue("J♥"), 10);
+assertEquals(getCardValue("Q♦"), 10);
+assertEquals(getCardValue("K♣"), 10);
+assertEquals(getCardValue("10♠"), 10);
+assertEquals(getCardValue("5♠"), 5);
 
 // Handling invalid cards
 try {
   getCardValue("invalid");
-
   // This line will not be reached if an error is thrown as expected
   console.error("Error was not thrown for invalid card");
 } catch (e) {}
 
+try {
+  getCardValue("A");
+  console.error("Expected error for 'A' but none was thrown");
+} catch (e) {}
+
+try {
+  getCardValue("♠");
+  console.error("Expected error for '♠' but none was thrown");
+} catch (e) {}
+
 // What other invalid card cases can you think of?

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -8,3 +8,21 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
 test(`should return false when denominator is zero`, () => {
   expect(isProperFraction(1, 0)).toEqual(false);
 });
+test(`should return false when numerator is zero`, () => {
+  expect(isProperFraction(0, 1)).toEqual(false);
+});
+test(`should return false when numerator is negative`, () => {
+  expect(isProperFraction(-1, 2)).toEqual(false);
+});
+test(`should return false when denominator is negative`, () => {
+  expect(isProperFraction(1, -2)).toEqual(false);
+});
+test(`should return false when denominator is infinity`, () => {
+  expect(isProperFraction(1, 23443243n)).toEqual(true);
+});
+test(`should return false when numerator is infinity`, () => {
+  expect(isProperFraction(23432434n, 10)).toEqual(false);
+});
+test(`should return true when denominator is bigger then numerator`, () => {
+  expect(isProperFraction(5, 10)).toEqual(true);
+});

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -11,8 +11,52 @@ test(`Should return 11 when given an ace card`, () => {
 
 // Suggestion: Group the remaining test data into these categories:
 //   Number Cards (2-10)
+test("Should return 2 for '2♠'", () => {
+    expect(getCardValue("2♠")).toEqual(2);
+  });
+
+  test("Should return 5 for '5♥'", () => {
+    expect(getCardValue("5♥")).toEqual(5);
+  });
+
+  test("Should return 9 for '9♦'", () => {
+    expect(getCardValue("9♦")).toEqual(9);
+  });
+
+  test("Should return 10 for '10♣'", () => {
+    expect(getCardValue("10♣")).toEqual(10);
+  });
+
 //   Face Cards (J, Q, K)
+test("Should return 10 for 'J♠'", () => {
+    expect(getCardValue("J♠")).toEqual(10);
+  });
+
+  test("Should return 10 for 'Q♥'", () => {
+    expect(getCardValue("Q♥")).toEqual(10);
+  });
+
+  test("Should return 10 for 'K♦'", () => {
+    expect(getCardValue("K♦")).toEqual(10);
+  });
+
 //   Invalid Cards
+ test("Should throw error for missing suit (e.g., 'A')", () => {
+  expect(() => getCardValue("A")).toThrow("Invalid card");
+});
+
+test("Should throw error for missing rank (e.g., '♠')", () => {
+  expect(() => getCardValue("♠")).toThrow("Invalid card");
+});
+
+test("Should throw error for null", () => {
+  expect(() => getCardValue(null)).toThrow("Invalid card");
+});
+
+test("Should throw error for undefined", () => {
+  expect(() => getCardValue(undefined)).toThrow("Invalid card");
+});
+
 
 // To learn how to test whether a function throws an error as expected in Jest,
 // please refer to the Jest documentation: