[client-v2,jdbc-v2] Fix reading Date/Time values #2727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

chernser merged 16 commits into main from 01/21/26/fix_client_reading_chrono_values

Feb 3, 2026

clickhouse-data/src/main/java/com/clickhouse/data/ClickHouseColumn.java

-Original file line number
+Diff line change
@@ Expand Up / @@ -80,6 +80,7 @@ public final class ClickHouseColumn implements Serializable { @@
         private ClickHouseAggregateFunction aggFuncType;
         private ClickHouseDataType dataType;
+        private ClickHouseDataType valueDataType; // in case of Simple Aggregate function it is first argument datatype
         private boolean nullable;
         private boolean hasDefault;
         private boolean lowCardinality;
@@ Expand Down Expand Up @@
                 column = new ClickHouseColumn(ClickHouseDataType.valueOf(matchedKeyword), name,
                         args.substring(startIndex, i), nullable, lowCardinality, params, nestedColumns);
                 column.aggFuncType = aggFunc;
+                if (!nestedColumns.isEmpty()) {
+                    column.valueDataType = nestedColumns.get(0).getDataType(); // init with first argument data type
+                }
                 fixedLength = false;
                 estimatedLength++;
             } else if (args.startsWith(KEYWORD_ARRAY, i)) {
@@ Expand Down Expand Up @@
                 boolean lowCardinality, List<String> parameters, List<ClickHouseColumn> nestedColumns, ClickHouseEnum enumConstants) {
             this.aggFuncType = null;
             this.dataType = ClickHouseChecker.nonNull(dataType, "dataType");
+            this.valueDataType = this.dataType;
             this.columnCount = 1;
             this.columnIndex = 0;
@@ Expand Down Expand Up @@
             return value;
         }
+        /**
+         * Returns column effective data type. In case of SimpleAggregateFunction
+         * returns type of the first column.
+         *
+         * @return ClickHouseDataType
+         */
+        public ClickHouseDataType getValueDataType() {
+            return  valueDataType;
+        }
         @Override
         public int hashCode() {
             final int prime = 31;
@@ Expand Down @@

client-v2/src/main/java/com/clickhouse/client/api/DataTypeUtils.java

-Original file line number
+Diff line change
@@ Expand Up / @@ -3,11 +3,18 @@ @@
     import com.clickhouse.client.api.data_formats.internal.BinaryStreamReader;
     import com.clickhouse.data.ClickHouseDataType;
+    import java.time.Duration;
     import java.time.Instant;
+    import java.time.LocalDate;
+    import java.time.LocalDateTime;
+    import java.time.LocalTime;
     import java.time.ZoneId;
+    import java.time.ZoneOffset;
     import java.time.format.DateTimeFormatter;
     import java.time.format.DateTimeFormatterBuilder;
     import java.time.temporal.ChronoField;
+    import java.time.temporal.ChronoUnit;
+    import java.time.temporal.TemporalUnit;
     import java.util.Objects;
     import static com.clickhouse.client.api.data_formats.internal.BinaryStreamReader.BASES;
@@ Expand Down Expand Up @@
             return Instant.ofEpochSecond(value, nanoSeconds);
         }
+        public static LocalDateTime localTimeFromTime64Integer(int precision, long value) {
+            int nanoSeconds = 0;
+            if (precision > 0) {
+                int factor = BinaryStreamReader.BASES[precision];
+                nanoSeconds = Math.abs((int) (value % factor)); // nanoseconds are stored separately and only positive values accepted
+                value /= factor;
+                if (nanoSeconds > 0L) {
+                    nanoSeconds *= BASES[9 - precision];
+                }
+            }
+            return LocalDateTime.ofEpochSecond(value, nanoSeconds, ZoneOffset.UTC);
+        }
+        /**
+         * Converts a {@link Duration} to a time string in the format {@code [-]HH:mm:ss[.nnnnnnnnn]}.
+         * <p>
+         * Unlike standard time formats, hours can exceed 24 and can be negative.
+         * The precision parameter controls the number of fractional second digits (0-9).
+         *
+         * @param duration  the duration to convert
+         * @param precision the number of fractional second digits (0-9)
+         * @return a string representation like {@code -999:59:59.123456789}
+         * @throws NullPointerException if {@code duration} is null
+         */
+        public static String durationToTimeString(Duration duration, int precision) {
+            Objects.requireNonNull(duration, "Duration required for durationToTimeString");
+            boolean negative = duration.isNegative();
+            if (negative) {
+                duration = duration.negated();
+            }
+            long totalSeconds = duration.getSeconds();
+            int nanos = duration.getNano();
+            long hours = totalSeconds / 3600;
+            int minutes = (int) ((totalSeconds % 3600) / 60);
+            int seconds = (int) (totalSeconds % 60);
+            StringBuilder sb = new StringBuilder();
+            if (negative) {
+                sb.append('-');
+            }
+            sb.append(hours);
+            sb.append(':');
+            if (minutes < 10) {
+                sb.append('0');
+            }
+            sb.append(minutes);
+            sb.append(':');
+            if (seconds < 10) {
+                sb.append('0');
+            }
+            sb.append(seconds);
+            if (precision > 0 && precision <= 9) {
+                sb.append('.');
+                // Format nanos with leading zeros, then truncate to precision
+                String nanosStr = String.format("%09d", nanos);
+                sb.append(nanosStr, 0, precision);
+            }
+            return sb.toString();
+        }
+        public static Duration localDateTimeToDuration(LocalDateTime localDateTime) {
+            return Duration.ofSeconds(localDateTime.toEpochSecond(ZoneOffset.UTC))
+                .plusNanos(localDateTime.getNano());
+        }
     }

...v2/src/main/java/com/clickhouse/client/api/data_formats/ClickHouseBinaryFormatReader.java

-Original file line number
+Diff line change
@@ Expand Up / @@ -15,6 +15,7 @@ @@
     import java.time.Instant;
     import java.time.LocalDate;
     import java.time.LocalDateTime;
+    import java.time.LocalTime;
     import java.time.OffsetDateTime;
     import java.time.ZonedDateTime;
     import java.time.temporal.TemporalAmount;
@@ Expand Down Expand Up @@
         LocalDate getLocalDate(int index);
+        LocalTime getLocalTime(String colName);
+        LocalTime getLocalTime(int index);
         LocalDateTime getLocalDateTime(String colName);
         LocalDateTime getLocalDateTime(int index);
@@ Expand Down @@

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[client-v2,jdbc-v2] Fix reading Date/Time values #2727

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!

Uh oh!