[repo] Fix slow init/teardown in cloud tests #2852
Merged
Merged
Conversation
…wait on operation
|
Repository collaborators can run the JMH benchmark suite against this PR by commenting: Optional regression threshold override (Δ% on Time or Alloc/op; defaults to 10%): Only one benchmark run per PR is active at a time — issuing a new |
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
… is pickedup correctly in CI
There was a problem hiding this comment.
Pull request overview
Speeds up ClickHouse Cloud integration tests by avoiding repeated per-suite database create/drop operations (which can trigger slow distributed DDL waits) and by adjusting the JWT cloud test to use an explicit endpoint.
Changes:
- Add
TEST_DB_NAMEsupport to reuse a workflow-created database and skip suite-level create/drop on Cloud. - Update the GitHub Actions cloud test job to generate, create, and always clean up a unique temporary database.
- Update the JWT cloud test to build a client with an explicit host and settings.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| client-v2/src/test/java/com/clickhouse/client/HttpTransportTests.java | Updates JWT cloud test client construction and endpoint selection via env var. |
| clickhouse-client/src/test/java/com/clickhouse/client/ClickHouseServerForTest.java | Adds env-driven database selection and skips Cloud create/drop when DB is externally managed; minor HTTP POST optimization. |
| .github/workflows/build.yml | Creates a per-run Cloud test DB, passes it via TEST_DB_NAME, and ensures cleanup always runs. |
mshustov
approved these changes
May 15, 2026
|
kurnoolsaketh
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each test suite tries to create a database. Database name is shared among all tests suites in the project. When run on the cloud it significantly slows down test execution.
This PR adds two flags to avoid extra queries.
Server output when creating database:
Checklist
Delete items not relevant to your PR: