Banner behavior

[awesomenode]

Hi!

I was trying to set the banner with libnetconf2, but multiple line banners weren't working. Digging into the code
libnetconf2 sets the banner in session_server_ssh.c:2040 ssh_bind_options_set(sbind, SSH_BIND_OPTIONS_BANNER, banner).

It seems that it actually sets the protocol string though (defined in RFC4253 4.2). Maybe that's why only 1 line banner is supported and the length is limited to 245?
Digging through libssh, there is an ssh_send_issue_banner() function that would actually set the actual banner message (defined in RFC4252 5.4).

Is banner leaf representing the protocol version string is the expected behavior?

Thanks!

[Roytak]

Hi, I think that you're completely right. The banner should be sent via ssh_send_issue_banner() instead. Should also still keep the protocol version, but just rename it in YANG and lift the 245 characters length from the actual banner. Will look into it.