[Bug] ModSetting中包含过多选项的Dropdown无法使用

[KCFindstr]

模块范围

UI

严重程度

Broken feature（功能不可用）

发生了什么？

我在Mod Setting添加了一个约包含500个选项的DropDown（动态生成的列表以允许用户自主载入角色皮肤，所以有可能包含大量选项）。点击该DropDown时，没有出现下拉框，log中报错。

复现步骤

1. 创建一个约500个选项的skinChoiceOptions，然后注册ModConfig：

    RitsuLibFramework.RegisterModSettings(modId, page => page
      .WithModDisplayName(ModSettingsText.LocString("settings_ui", "LINKURA_MOD.mod_title", "LinkuraMod"))
      .WithTitle(ModSettingsText.LocString("settings_ui", "LINKURA_MOD.settings_title", "LinkuraMod Settings"))
      .AddSection("skin", section => section
        .WithTitle(SettingsText("Skin"))
        .AddCustom(
          "kaho_skin_preview",
          SettingsText("Kaho Preview"),
          _ => CreateKahoSkinPreview())
        .AddChoice(
          "kaho_skin",
          SettingsText("Kaho Skin"),
          _kahoSkinBinding,
          skinChoiceOptions,
          presentation: ModSettingsChoicePresentation.Dropdown))

2. 打开游戏进入模组配置UI，尝试点击这个DropDown

期望行为

DropDown正常显示并带有垂直滚动条

日志 / 堆栈

ERROR: System.ArgumentException: '0' cannot be greater than -23546.
   at System.Math.ThrowMinMaxException[T](T min, T max)
   at STS2RitsuLib.Settings.ModSettingsDropdownChoiceControl`1.LayoutDropdownInViewport() in /home/runner/work/STS2-RitsuLib/STS2-RitsuLib/Settings/ModSettingsUi/Controls/ModSettingsUiControls.cs:line 1499
   at STS2RitsuLib.Settings.ModSettingsDropdownChoiceControl`1.OpenDropdown() in /home/runner/work/STS2-RitsuLib/STS2-RitsuLib/Settings/ModSettingsUi/Controls/ModSettingsUiControls.cs:line 1214
   at STS2RitsuLib.Settings.ModSettingsDropdownChoiceControl`1.OnFacePressed() in /home/runner/work/STS2-RitsuLib/STS2-RitsuLib/Settings/ModSettingsUi/Controls/ModSettingsUiControls.cs:line 1156
   at Godot.Callable.<From>g__Trampoline|1_0(Object delegateObj, NativeVariantPtrArgs args, godot_variant& ret)
   at Godot.DelegateUtils.InvokeWithVariantArgs(IntPtr delegateGCHandle, Void* trampoline, godot_variant** args, Int32 argc, godot_variant* outRet)
   at: void Godot.NativeInterop.ExceptionUtils.LogException(System.Exception) (:0)
   C# backtrace (most recent call first):
       [0] void Godot.GD.PushError(string)
       [1] void Godot.NativeInterop.ExceptionUtils.LogException(System.Exception)
       [2] void Godot.DelegateUtils.InvokeWithVariantArgs(nint, System.Void*, Godot.NativeInterop.godot_variant**, int, Godot.NativeInterop.godot_variant*)

RitsuLib 版本

0.2.29

运行环境

Windows 11, STS2 0.103.2

[ritsukage-local-analyzer]

Warning

此分析由 AI 自动生成，仅供开发者参考，最终判断请以人工确认为准。如有疑问建议结合本地环境进一步复现确认。

摘要

当 ModSettingsDropdownChoiceControl 包含约 500 个选项时，下拉面板的组合最小尺寸远超视口高度，导致 LayoutDropdownInViewport() 中 Mathf.Clamp 的 min 参数（vr.Position.Y，一般为 0）大于 max 参数（vr.End.Y - panelSize.Y，此时为负值），触发 ArgumentException 并使 Dropdown 完全无法打开。根因是布局逻辑未处理面板尺寸大于视口的情况，同时下拉列表缺少 ScrollContainer 包裹，即使修复崩溃，大量选项下也无法滚动浏览。建议在 LayoutDropdownInViewport 中增加 max < min 的保护，并为 _dropList 引入滚动容器。

问题描述

期望行为

Dropdown 正常弹出，面板带有垂直滚动条，用户可以滚动浏览全部约 500 个选项。

实际行为

点击 Dropdown 后无下拉面板出现，日志抛出异常 ArgumentException: '0' cannot be greater than -23546，DropDown 功能完全不可用。

复现步骤

1. 构造约 500 个选项的列表 skinChoiceOptions，通过 AddChoice 注册为 ModSettingsChoicePresentation.Dropdown。
2. 打开游戏进入模组配置页面，点击该 Dropdown。

环境与版本

• OS: Windows 11
• 游戏: STS2 0.103.2
• RitsuLib: 0.2.29

日志与附件

点击展开完整堆栈

ERROR: System.ArgumentException: '0' cannot be greater than -23546.
   at System.Math.ThrowMinMaxException[T](T min, T max)
   at STS2RitsuLib.Settings.ModSettingsDropdownChoiceControl`1.LayoutDropdownInViewport() in /home/runner/work/STS2-RitsuLib/STS2-RitsuLib/Settings/ModSettingsUi/Controls/ModSettingsUiControls.cs:line 1499
   at STS2RitsuLib.Settings.ModSettingsDropdownChoiceControl`1.OpenDropdown() in /home/runner/work/STS2-RitsuLib/STS2-RitsuLib/Settings/ModSettingsUi/Controls/ModSettingsUiControls.cs:line 1214
   at STS2RitsuLib.Settings.ModSettingsDropdownChoiceControl`1.OnFacePressed() in /home/runner/work/STS2-RitsuLib/STS2-RitsuLib/Settings/ModSettingsUi/Controls/ModSettingsUiControls.cs:line 1156
   at Godot.Callable.<From>g__Trampoline|1_0(Object delegateObj, NativeVariantPtrArgs args, godot_variant& ret)
   at Godot.DelegateUtils.InvokeWithVariantArgs(IntPtr delegateGCHandle, Void* trampoline, godot_variant** args, Int32 argc, godot_variant* outRet)

分析

可能原因与涉及面

崩溃直接原因 — ModSettingsUiControls.cs:1497-1501：

var maxX = vr.End.X - panelSize.X;
var maxY = vr.End.Y - panelSize.Y;
desiredTopLeft = new(
    Mathf.Clamp(desiredTopLeft.X, vr.Position.X, maxX),
    Mathf.Clamp(desiredTopLeft.Y, vr.Position.Y, maxY));

• 每行高度约 38px，加上 separation（默认 8px），500 行约产生 23,000px 的组合最小高度。
• panelSize.Y 取自 _dropPanel.GetCombinedMinimumSize()，在此场景下远超视口高度（如 1080px）。
• maxY = vr.End.Y - panelSize.Y 变为负数（堆栈中为 -23546，与 ~23,000px 估算吻合）。
• Mathf.Clamp(value, 0, -23546) 中 min > max，抛出 ArgumentException。

滚动缺失 — _dropList 是 VBoxContainer，并无 ScrollContainer 包裹（见 BuildDropdownShell() 第 1184–1192 行）。即使修复崩溃，500 行面板将延伸至屏幕外，用户依旧无法操作底部选项。

相关模块或配置（若可从上下文推断）

• ModSettingsDropdownChoiceControl<TValue>.LayoutDropdownInViewport() — 需增加 max < min 保护。
• ModSettingsDropdownChoiceControl<TValue>.BuildDropdownShell() — 需将 _dropList 放入 ScrollContainer 或对 _dropPanel 设置最大高度并启用裁剪/滚动。
• 同文件第 2580–2583 行存在另一处相同模式的 LayoutDropdownInViewport（疑似为 ActionsDropdown 使用），可能面临同类问题。

验证建议

• 用约 500 个选项构造 Dropdown，确认崩溃不再发生且面板可显示。
• 验证面板在视口高度不足以容纳全部选项时，出现垂直滚动条且可正常滚动。
• 验证少量选项（如 3–5 个）的 Dropdown 行为无回归 — 面板应紧贴按钮下方弹出，不出现多余滚动条。
• 检查同文件中 ActionsDropdown 的 LayoutDropdownInViewport（约 2580 行）是否存在同类 max < min 风险。

风险与未决

• 引入 ScrollContainer 后需要调整键盘/手柄导航逻辑（WireRowFocusNeighbors、_UnhandledInput 中的上下键处理），确保焦点在滚动区域内正常工作。
• 500 个选项的即时渲染可能产生性能压力；若有必要可考虑虚拟化（仅渲染可见行），但当前优先修复崩溃与可滚动性。

---

English translation

Click to expand

Summary

When ModSettingsDropdownChoiceControl holds ~500 options, the combined minimum size of the dropdown panel greatly exceeds the viewport height. In LayoutDropdownInViewport(), this causes Mathf.Clamp's min parameter (vr.Position.Y, typically 0) to be larger than its max parameter (vr.End.Y - panelSize.Y, which becomes negative), throwing ArgumentException and preventing the dropdown from opening. The root cause is that the layout logic does not handle the case where the panel is taller than the viewport. Additionally, the dropdown list lacks a ScrollContainer, so even after fixing the crash, users cannot scroll through a large option set. Recommend adding a max < min guard in LayoutDropdownInViewport and wrapping _dropList in a scroll container.

Problem Description

Expected Behavior

Dropdown opens normally with a vertical scrollbar, allowing users to scroll through all ~500 options.

Actual Behavior

Clicking the dropdown produces no visible panel. The log shows ArgumentException: '0' cannot be greater than -23546. The dropdown is completely non-functional.

Steps to Reproduce

1. Build a list of ~500 options (skinChoiceOptions), register via AddChoice with ModSettingsChoicePresentation.Dropdown.
2. Launch the game, open the mod settings UI, and click the dropdown.

Environment & Version

• OS: Windows 11
• Game: STS2 0.103.2
• RitsuLib: 0.2.29

Logs & Attachments

Click to expand full stack trace

ERROR: System.ArgumentException: '0' cannot be greater than -23546.
   at System.Math.ThrowMinMaxException[T](T min, T max)
   at STS2RitsuLib.Settings.ModSettingsDropdownChoiceControl`1.LayoutDropdownInViewport() in .../ModSettingsUiControls.cs:line 1499
   at STS2RitsuLib.Settings.ModSettingsDropdownChoiceControl`1.OpenDropdown() in .../ModSettingsUiControls.cs:line 1214
   at STS2RitsuLib.Settings.ModSettingsDropdownChoiceControl`1.OnFacePressed() in .../ModSettingsUiControls.cs:line 1156
   ...

Analysis

Root Cause & Scope

Direct crash cause — ModSettingsUiControls.cs:1497-1501:

var maxX = vr.End.X - panelSize.X;
var maxY = vr.End.Y - panelSize.Y;
desiredTopLeft = new(
    Mathf.Clamp(desiredTopLeft.X, vr.Position.X, maxX),
    Mathf.Clamp(desiredTopLeft.Y, vr.Position.Y, maxY));

• Each row is ~38px tall plus ~8px separation, so 500 rows produce a combined minimum height of ~23,000px.
• panelSize.Y comes from _dropPanel.GetCombinedMinimumSize(), far exceeding a typical viewport height (e.g., 1080px).
• maxY = vr.End.Y - panelSize.Y becomes negative (-23546 in the stack trace, consistent with ~23,000px estimate).
• Mathf.Clamp(value, 0, -23546) has min > max, throwing ArgumentException.

Missing scrolling — _dropList is a plain VBoxContainer with no ScrollContainer wrapper (see BuildDropdownShell() lines 1184–1192). Even after fixing the crash, a 500-row panel would extend off-screen with no way to reach the bottom items.

Related Modules

• ModSettingsDropdownChoiceControl<TValue>.LayoutDropdownInViewport() — needs max < min guard.
• ModSettingsDropdownChoiceControl<TValue>.BuildDropdownShell() — should wrap _dropList in a ScrollContainer or clamp _dropPanel max height with clipping/scrolling.
• A duplicate LayoutDropdownInViewport pattern exists at approximately line 2580 (likely for ActionsDropdown) and may be vulnerable to the same issue.

Verification Checklist

• Construct a dropdown with ~500 options; confirm no crash and panel appears.
• Verify a vertical scrollbar appears when the panel is taller than the viewport, and scrolling works.
• Verify no regression with few options (3–5): panel should open directly below the face button without an unnecessary scrollbar.
• Check the ActionsDropdown LayoutDropdownInViewport (~line 2580) for the same max < min risk.

Risks & Open Questions

• Adding a ScrollContainer requires adjusting keyboard/gamepad navigation (WireRowFocusNeighbors, arrow-key handling in _UnhandledInput) to ensure focus works correctly within the scroll area.
• Rendering 500 rows at once may cause performance issues; virtualization (rendering only visible rows) could be considered as a follow-up, but fixing the crash and adding scrollability should come first.

---

工具侧记录

• BAKAOLC/STS2-RitsuLib#36 · 退出码 0 · 进程 179.35s
• deepseek-v4-pro · API 178101ms · 10 轮 · ↓53079 ↑4958 · 缓存读115968 写0 · $0.4473

[BAKAOLC]

已确认原因和工作链路，预计于下个版本中修复

[BAKAOLC]

预计效果如上