From 8fdd14304e6c8a1edb8668811e5bd44b88de282c Mon Sep 17 00:00:00 2001 From: Ray Chen Date: Wed, 22 Apr 2026 16:24:10 -0700 Subject: [PATCH 1/5] Moved package-signed publish to latter step --- .../stages/archetype-java-release-batch.yml | 21 +++++++------------ 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/eng/pipelines/templates/stages/archetype-java-release-batch.yml b/eng/pipelines/templates/stages/archetype-java-release-batch.yml index 4815f1afb6ac..59bff6774908 100644 --- a/eng/pipelines/templates/stages/archetype-java-release-batch.yml +++ b/eng/pipelines/templates/stages/archetype-java-release-batch.yml @@ -53,18 +53,6 @@ stages: Artifacts: ${{parameters.Artifacts}} ArtifactDirectory: $(Pipeline.Workspace)/packages - # Publish the ESRP signed directory. This will still be used by the - # Dev feed publish. - - template: /eng/common/pipelines/templates/steps/publish-1es-artifact.yml - parameters: - ArtifactPath: '$(Pipeline.Workspace)/packages' - ArtifactName: 'packages-signed' - - # Downloading the ESRP signed artifacts - - download: current - displayName: 'Download Signed Artifacts' - artifact: packages-signed - # Setup Maven mirror settings and authenticate with Azure Artifacts - template: /eng/pipelines/templates/steps/maven-authenticate.yml parameters: @@ -76,10 +64,17 @@ stages: - template: tools/gpg/gpg.yml@azure-sdk-build-tools - template: /eng/pipelines/templates/steps/gpg-sign-and-flatten.yml parameters: - ArtifactDirectory: $(Pipeline.Workspace)/packages-signed + ArtifactDirectory: $(Pipeline.Workspace)/packages OutputDirectory: $(Pipeline.Workspace)/packages-esrp-gpg-signed FlattenedESRPDirectory: $(Pipeline.Workspace)/packages-esrp-flattened + # Publish the ESRP signed directory. This will still be used by the + # Dev feed publish. + - template: /eng/common/pipelines/templates/steps/publish-1es-artifact.yml + parameters: + ArtifactPath: '$(Pipeline.Workspace)/packages' + ArtifactName: 'packages-signed' + # The packages-esrp-flattened will be used for the ESRP publish - template: /eng/common/pipelines/templates/steps/publish-1es-artifact.yml parameters: From 5841d6dcf2b28bbce99313e91b224bd0e14755d0 Mon Sep 17 00:00:00 2001 From: Ray Chen Date: Wed, 22 Apr 2026 17:11:49 -0700 Subject: [PATCH 2/5] Bumpped apiview steps in CI yml --- eng/pipelines/templates/jobs/ci.yml | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/eng/pipelines/templates/jobs/ci.yml b/eng/pipelines/templates/jobs/ci.yml index 987f15ee9ed1..30d92bbc09cd 100644 --- a/eng/pipelines/templates/jobs/ci.yml +++ b/eng/pipelines/templates/jobs/ci.yml @@ -266,6 +266,20 @@ jobs: workingDirectory: $(Pipeline.Workspace) displayName: Update package properties with namespaces + - template: /eng/common/pipelines/templates/steps/create-apireview.yml + parameters: + PackageInfoFiles: + - ${{ each artifact in parameters.ReleaseArtifacts }}: + - $(Build.ArtifactStagingDirectory)/PackageInfo/${{artifact.name}}.json + + - template: /eng/common/pipelines/templates/steps/detect-api-changes.yml + + - template: /eng/common/pipelines/templates/steps/validate-all-packages.yml + parameters: + PackageInfoFiles: + - ${{ each artifact in parameters.ReleaseArtifacts }}: + - $(Build.ArtifactStagingDirectory)/PackageInfo/${{artifact.name}}.json + - template: /eng/common/pipelines/templates/steps/publish-1es-artifact.yml parameters: ArtifactPath: $(Build.ArtifactStagingDirectory) @@ -288,20 +302,6 @@ jobs: SbomEnabled: false CustomCondition: or(eq(variables['CaptureRepositoryOnFailure'], 'true'), and(failed(), eq(variables['Build.Reason'],'Schedule'))) - - template: /eng/common/pipelines/templates/steps/create-apireview.yml - parameters: - PackageInfoFiles: - - ${{ each artifact in parameters.ReleaseArtifacts }}: - - $(Build.ArtifactStagingDirectory)/PackageInfo/${{artifact.name}}.json - - - template: /eng/common/pipelines/templates/steps/detect-api-changes.yml - - - template: /eng/common/pipelines/templates/steps/validate-all-packages.yml - parameters: - PackageInfoFiles: - - ${{ each artifact in parameters.ReleaseArtifacts }}: - - $(Build.ArtifactStagingDirectory)/PackageInfo/${{artifact.name}}.json - - template: /eng/pipelines/templates/steps/post-job-cleanup.yml - job: 'Analyze' From c8b7e08c8436272fad05a81eff40ed97ebc50076 Mon Sep 17 00:00:00 2001 From: Ray Chen Date: Thu, 23 Apr 2026 10:15:20 -0700 Subject: [PATCH 3/5] Fixed 404 link --- sdk/template/azure-template-stress/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/template/azure-template-stress/README.md b/sdk/template/azure-template-stress/README.md index 5c641711b85e..350f6b90eabd 100644 --- a/sdk/template/azure-template-stress/README.md +++ b/sdk/template/azure-template-stress/README.md @@ -200,7 +200,7 @@ This would allow you to distinguish telemetry coming from different containers. You would need to adjust the workbook to accommodate those changes. In addition to `test.run_duration`, we're also collecting: -- [JVM metrics](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/runtime-telemetry/runtime-telemetry-java8/library/README.md) measured by OpenTelemetry: +- [JVM metrics](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/runtime-telemetry/README.md) measured by OpenTelemetry: - CPU and memory usage - GC stats - Thread count From 130d99fc47b01a73553ea02c96c6182bce5ddeca Mon Sep 17 00:00:00 2001 From: Ray Chen Date: Thu, 23 Apr 2026 13:40:32 -0700 Subject: [PATCH 4/5] Revert "Bumpped apiview steps in CI yml" This reverts commit 5841d6dcf2b28bbce99313e91b224bd0e14755d0. --- eng/pipelines/templates/jobs/ci.yml | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/eng/pipelines/templates/jobs/ci.yml b/eng/pipelines/templates/jobs/ci.yml index 30d92bbc09cd..987f15ee9ed1 100644 --- a/eng/pipelines/templates/jobs/ci.yml +++ b/eng/pipelines/templates/jobs/ci.yml @@ -266,20 +266,6 @@ jobs: workingDirectory: $(Pipeline.Workspace) displayName: Update package properties with namespaces - - template: /eng/common/pipelines/templates/steps/create-apireview.yml - parameters: - PackageInfoFiles: - - ${{ each artifact in parameters.ReleaseArtifacts }}: - - $(Build.ArtifactStagingDirectory)/PackageInfo/${{artifact.name}}.json - - - template: /eng/common/pipelines/templates/steps/detect-api-changes.yml - - - template: /eng/common/pipelines/templates/steps/validate-all-packages.yml - parameters: - PackageInfoFiles: - - ${{ each artifact in parameters.ReleaseArtifacts }}: - - $(Build.ArtifactStagingDirectory)/PackageInfo/${{artifact.name}}.json - - template: /eng/common/pipelines/templates/steps/publish-1es-artifact.yml parameters: ArtifactPath: $(Build.ArtifactStagingDirectory) @@ -302,6 +288,20 @@ jobs: SbomEnabled: false CustomCondition: or(eq(variables['CaptureRepositoryOnFailure'], 'true'), and(failed(), eq(variables['Build.Reason'],'Schedule'))) + - template: /eng/common/pipelines/templates/steps/create-apireview.yml + parameters: + PackageInfoFiles: + - ${{ each artifact in parameters.ReleaseArtifacts }}: + - $(Build.ArtifactStagingDirectory)/PackageInfo/${{artifact.name}}.json + + - template: /eng/common/pipelines/templates/steps/detect-api-changes.yml + + - template: /eng/common/pipelines/templates/steps/validate-all-packages.yml + parameters: + PackageInfoFiles: + - ${{ each artifact in parameters.ReleaseArtifacts }}: + - $(Build.ArtifactStagingDirectory)/PackageInfo/${{artifact.name}}.json + - template: /eng/pipelines/templates/steps/post-job-cleanup.yml - job: 'Analyze' From 92dd20127f8c23f2bd328b36a664d3c09577a835 Mon Sep 17 00:00:00 2001 From: Ray Chen Date: Thu, 23 Apr 2026 13:43:38 -0700 Subject: [PATCH 5/5] Temporarily removed the dead links to unblock the CI failure --- sdk/template/azure-sdk-template-three/README.md | 3 +-- sdk/template/azure-sdk-template-two/README.md | 3 +-- sdk/template/azure-sdk-template/README.md | 3 +-- sdk/template/azure-template-stress/README.md | 3 --- 4 files changed, 3 insertions(+), 9 deletions(-) diff --git a/sdk/template/azure-sdk-template-three/README.md b/sdk/template/azure-sdk-template-three/README.md index 2e9d7ed385cc..c847dc72be86 100644 --- a/sdk/template/azure-sdk-template-three/README.md +++ b/sdk/template/azure-sdk-template-three/README.md @@ -113,7 +113,7 @@ If the package, or a related package supports it, include tips for logging or en Azure SDKs for Java provide a consistent logging story to help aid in troubleshooting application errors and expedite their resolution. The logs produced will capture the flow of an application before reaching the terminal state to help -locate the root issue. View the [logging][logging] wiki for guidance about enabling logging. +locate the root issue. ### Default HTTP Client @@ -148,7 +148,6 @@ This project has adopted the [Microsoft Open Source Code of Conduct][coc]. For m [style-guide-msft]: https://learn.microsoft.com/style-guide/capitalization [jdk]: https://learn.microsoft.com/java/azure/jdk/?view=azure-java-stable -[logging]: https://github.com/Azure/azure-sdk-for-java/wiki/Logging-in-Azure-SDK [cla]: https://cla.microsoft.com [coc]: https://opensource.microsoft.com/codeofconduct/ [coc_faq]: https://opensource.microsoft.com/codeofconduct/faq/ diff --git a/sdk/template/azure-sdk-template-two/README.md b/sdk/template/azure-sdk-template-two/README.md index 4a8c0ad99e88..9ddf6a30a335 100644 --- a/sdk/template/azure-sdk-template-two/README.md +++ b/sdk/template/azure-sdk-template-two/README.md @@ -113,7 +113,7 @@ If the package, or a related package supports it, include tips for logging or en Azure SDKs for Java provide a consistent logging story to help aid in troubleshooting application errors and expedite their resolution. The logs produced will capture the flow of an application before reaching the terminal state to help -locate the root issue. View the [logging][logging] wiki for guidance about enabling logging. +locate the root issue. ### Default HTTP Client @@ -148,7 +148,6 @@ This project has adopted the [Microsoft Open Source Code of Conduct][coc]. For m [style-guide-msft]: https://learn.microsoft.com/style-guide/capitalization [jdk]: https://learn.microsoft.com/java/azure/jdk/?view=azure-java-stable -[logging]: https://github.com/Azure/azure-sdk-for-java/wiki/Logging-in-Azure-SDK [cla]: https://cla.microsoft.com [coc]: https://opensource.microsoft.com/codeofconduct/ [coc_faq]: https://opensource.microsoft.com/codeofconduct/faq/ diff --git a/sdk/template/azure-sdk-template/README.md b/sdk/template/azure-sdk-template/README.md index f1ce51214803..fe0da7300595 100644 --- a/sdk/template/azure-sdk-template/README.md +++ b/sdk/template/azure-sdk-template/README.md @@ -113,7 +113,7 @@ If the package, or a related package supports it, include tips for logging or en Azure SDKs for Java provide a consistent logging story to help aid in troubleshooting application errors and expedite their resolution. The logs produced will capture the flow of an application before reaching the terminal state to help -locate the root issue. View the [logging][logging] wiki for guidance about enabling logging. +locate the root issue. ### Default HTTP Client @@ -148,7 +148,6 @@ This project has adopted the [Microsoft Open Source Code of Conduct][coc]. For m [style-guide-msft]: https://learn.microsoft.com/style-guide/capitalization [jdk]: https://learn.microsoft.com/java/azure/jdk/?view=azure-java-stable -[logging]: https://github.com/Azure/azure-sdk-for-java/wiki/Logging-in-Azure-SDK [cla]: https://cla.microsoft.com [coc]: https://opensource.microsoft.com/codeofconduct/ [coc_faq]: https://opensource.microsoft.com/codeofconduct/faq/ diff --git a/sdk/template/azure-template-stress/README.md b/sdk/template/azure-template-stress/README.md index 350f6b90eabd..b16ca1fff2e5 100644 --- a/sdk/template/azure-template-stress/README.md +++ b/sdk/template/azure-template-stress/README.md @@ -171,8 +171,6 @@ You may also control the verbosity of logs that go to Application Insights - see Since logs are hard to query and are extremely verbose (in case of high-scale stress tests), we're relying on metrics and workbooks for test result analysis. -See also [Logging in Azure SDK][logging-azure-sdk]. - ### Metrics While some Azure SDKs provide custom metrics, we're going to collect generic test metrics and build queries/workbooks on top of them, @@ -254,4 +252,3 @@ thread pool issues, or other performance issues in the code. So make sure to con [deploy_stress_test]: https://github.com/Azure/azure-sdk-tools/blob/main/tools/stress-cluster/chaos/README.md#deploying-a-stress-test [stress_test_layout]: https://github.com/Azure/azure-sdk-tools/blob/main/tools/stress-cluster/chaos/README.md#layout [opentelemetry-logback]: https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/logback/logback-appender-1.0/library -[logging-azure-sdk]: https://github.com/Azure/azure-sdk-for-java/wiki/Logging-in-Azure-SDK