fix: address CodeRabbit round 3 findings

- VotableGrade.svelte: remove @ts-expect-error; append ?tab=atcoder after resolve()
- e2e/votes.spec.ts: add clarifying comment on intentional voteForm visibility check
- .claude/rules/testing.md: rename cleanup subsection to "Integration Tests and Tests
  with Real Side Effects"; add note that it does not apply to Prisma-mock unit tests

Skip: locals.user?.is_validated -> session.user (session.user type lacks is_validated)
Skip: sitemap.xml /votes/[slug] exclusion (defensive pattern, not harmful)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: river0525

.claude/rules/testing.md

@@ -103,7 +103,9 @@ function mockCount(value: number) {
 
 Extract `mockFindUnique`, `mockFindMany`, and `mockCount` as the standard trio for service tests that touch a single Prisma model. Add `mockCreate`, `mockTransaction`, and `mockDelete` when those operations are also tested.
 
-### Cleanup for Tests with Real Side Effects
+### Cleanup for Integration Tests and Tests with Real Side Effects
+
+This does not apply to standard service layer unit tests that use Prisma mocks.
 
 If a test performs real DB mutations, file system changes, external API calls, or other stateful side effects that persist beyond the test (e.g., integration tests, seed scripts), wrap assertions in `try/finally` — a failing assertion skips cleanup and contaminates later tests:
 

e2e/votes.spec.ts

@@ -131,7 +131,8 @@ test.describe('vote detail page (/votes/[slug])', () => {
       const isUnverified = await unverifiedMessage.isVisible();
       test.skip(isUnverified, 'test user is not AtCoder-verified');
 
-      // Vote form with grade buttons is rendered for logged-in verified users
+      // Explicit check: voteForm is already guaranteed visible by the or() wait above,
+      // but this documents the expected state for verified users.
       await expect(voteForm).toBeVisible({
         timeout: TIMEOUT,
       });

src/features/votes/components/VotableGrade.svelte

@@ -37,8 +37,7 @@
   // Use task_id as a deterministic component ID to avoid SSR/hydration mismatches.
   const componentId = taskResult.task_id;
 
-  // @ts-expect-error svelte-check TS2554: AppTypes declaration merging causes RouteId to resolve as string, requiring params. Runtime behavior is correct.
-  const editProfileHref = resolve(EDIT_PROFILE_PAGE + '?tab=atcoder');
+  const editProfileHref = `${resolve(EDIT_PROFILE_PAGE)}?tab=atcoder`;
 
   let selectedVoteGrade = $state<TaskGrade>();
   let showForm = $state(false);