diff --git a/lib/public/components/Filters/common/FilteringModel.js b/lib/public/components/Filters/common/FilteringModel.js index 545d848190..19e59f7b65 100644 --- a/lib/public/components/Filters/common/FilteringModel.js +++ b/lib/public/components/Filters/common/FilteringModel.js @@ -140,6 +140,30 @@ export class FilteringModel extends Observable { this.notify(); } + /** + * Look for parameters used for filtering in URL and apply them in the layout if it exists + * @returns {undefined} + */ + async setFilterFromURL() { + const { params: { page = '', filter = {} } } = this._router; + + if (!(this._pageIdentifier === page)) { + return; + } + + for (const [key, value] of Object.entries(filter)) { + const filterModel = this._filters[key]; + + if (!filterModel) { + continue; + } + + filterModel.normalized = value; + } + + this.notify(); + } + /** * Add new filter * diff --git a/lib/public/components/runEorReasons/runEorReasonSelection.js b/lib/public/components/runEorReasons/runEorReasonSelection.js index dbe86cde87..c7a3ad14a3 100644 --- a/lib/public/components/runEorReasons/runEorReasonSelection.js +++ b/lib/public/components/runEorReasons/runEorReasonSelection.js @@ -22,6 +22,7 @@ import { h } from '/js/src/index.js'; */ export const eorReasonFilterComponent = (eorReasonFilterModel, eorReasonTypes) => { const eorReasonsCategories = [...new Set(eorReasonTypes.map(({ category }) => category))]; + const { category: currentCategory, title: currentTitle } = eorReasonFilterModel; return [ h('.flex-row', [ @@ -36,7 +37,7 @@ export const eorReasonFilterComponent = (eorReasonFilterModel, eorReasonTypes) = h('option', { selected: eorReasonFilterModel.category === '', value: '' }, '-'), eorReasonsCategories.map((category, index) => h( `option#eorCategory${index}`, - { key: category, value: category }, + { key: category, value: category, selected: category === currentCategory }, category, )), ], @@ -54,7 +55,7 @@ export const eorReasonFilterComponent = (eorReasonFilterModel, eorReasonTypes) = .filter((reason) => reason.category === eorReasonFilterModel.category) .map(({ title }, index) => h( `option#eorTitle${index}`, - { key: title, value: title }, + { key: title, value: title, selected: title === currentTitle }, title || '(empty)', )), ], diff --git a/lib/public/views/DataPasses/ActiveColumns/dataPassesActiveColumns.js b/lib/public/views/DataPasses/ActiveColumns/dataPassesActiveColumns.js index 7fad95a33b..e0b6d87316 100644 --- a/lib/public/views/DataPasses/ActiveColumns/dataPassesActiveColumns.js +++ b/lib/public/views/DataPasses/ActiveColumns/dataPassesActiveColumns.js @@ -20,7 +20,7 @@ import { h } from '/js/src/index.js'; import { formatDataPassName } from '../format/formatDataPassName.js'; import { formatDataPassStatusHistory } from '../format/formatStatusHistory.js'; import { checkboxes } from '../../../components/Filters/common/filters/checkboxFilter.js'; -import { textInputFilter } from '../../../components/Filters/common/filters/textInputFilter.js'; +import { textFilter } from '../../../components/Filters/common/filters/textFilter.js'; /** * List of active columns for a generic data passes table @@ -35,7 +35,7 @@ export const dataPassesActiveColumns = { visible: true, sortable: true, format: (_, dataPass) => formatDataPassName(dataPass), - filter: (filteringModel) => textInputFilter(filteringModel, 'names', 'e.g. LHC22a_apass1, ...', 'w-75'), + filter: (filteringModel) => textFilter(filteringModel.get('names'), { class: 'w-75 mt1', placeholder: 'e.g. LHC22a, lhc23b, ...' }), balloon: true, classes: 'w-20', }, @@ -102,7 +102,7 @@ export const dataPassesActiveColumns = { nonPhysicsProductions: { name: 'Include nonphysics productions', - filter: (filteringModel) => checkboxes(filteringModel.get('include[byName]')), + filter: (filteringModel) => checkboxes(filteringModel.get('permittedNonPhysicsNames')), visible: false, }, }; diff --git a/lib/public/views/DataPasses/DataPassesOverviewModel.js b/lib/public/views/DataPasses/DataPassesOverviewModel.js index 51f3cdb4e8..3be195e0b7 100644 --- a/lib/public/views/DataPasses/DataPassesOverviewModel.js +++ b/lib/public/views/DataPasses/DataPassesOverviewModel.js @@ -31,13 +31,14 @@ export class DataPassesOverviewModel extends OverviewPageModel { router, { names: new TextTokensFilterModel(), - 'include[byName]': new SelectionModel({ + permittedNonPhysicsNames: new SelectionModel({ availableOptions: NON_PHYSICS_PRODUCTIONS_NAMES_WORDS.map((word) => ({ label: word.toUpperCase(), value: word })), }), }, ); this._filteringModel.pageIdentifier = pageIdentifier; + this._filteringModel.setFilterFromURL(); this._filteringModel.visualChange$.bubbleTo(this); this._filteringModel.observe(() => { this._pagination.currentPage = 1; diff --git a/lib/public/views/Environments/Overview/EnvironmentOverviewModel.js b/lib/public/views/Environments/Overview/EnvironmentOverviewModel.js index 3c9f176f12..5e220e758a 100644 --- a/lib/public/views/Environments/Overview/EnvironmentOverviewModel.js +++ b/lib/public/views/Environments/Overview/EnvironmentOverviewModel.js @@ -51,10 +51,10 @@ export class EnvironmentOverviewModel extends OverviewPageModel { ); this._filteringModel.pageIdentifier = pageIdentifier; + this._filteringModel.setFilterFromURL(); this._filteringModel.observe(() => this._applyFilters(true)); this._filteringModel.visualChange$?.bubbleTo(this); - this.reset(false); const updateDebounceTime = () => { this._debouncedLoad = debounce(this.load.bind(this), model.inputDebounceTime); }; @@ -92,7 +92,7 @@ export class EnvironmentOverviewModel extends OverviewPageModel { /** * Reset all filtering models * @param {boolean} fetch Whether to refetch all data after filters have been reset - * @param {boolean} [clearUrl=false] if true filters will be removed from the url + * @param {boolean} resetUrl Whether to remove all the active filters from the urls * @return {void} */ resetFiltering(fetch = true, clearUrl = false) { diff --git a/lib/public/views/LhcFills/Overview/LhcFillsOverviewModel.js b/lib/public/views/LhcFills/Overview/LhcFillsOverviewModel.js index 1bf04f6878..04d746aea3 100644 --- a/lib/public/views/LhcFills/Overview/LhcFillsOverviewModel.js +++ b/lib/public/views/LhcFills/Overview/LhcFillsOverviewModel.js @@ -52,10 +52,9 @@ export class LhcFillsOverviewModel extends OverviewPageModel { ); this._filteringModel.pageIdentifier = pageIdentifier; + this._filteringModel.setFilterFromURL(); this._filteringModel.observe(() => this._applyFilters()); this._filteringModel.visualChange$.bubbleTo(this); - - this.reset(false); } /** @@ -72,10 +71,7 @@ export class LhcFillsOverviewModel extends OverviewPageModel { * @inheritDoc */ getRootEndpoint() { - const params = { - filter: this.filteringModel.normalized, - }; - return buildUrl('/api/lhcFills', params); + return buildUrl('/api/lhcFills', { filter: this.filteringModel.normalized }); } /** diff --git a/lib/public/views/Logs/Overview/LogsOverviewModel.js b/lib/public/views/Logs/Overview/LogsOverviewModel.js index f2d531335b..b3591d4e0b 100644 --- a/lib/public/views/Logs/Overview/LogsOverviewModel.js +++ b/lib/public/views/Logs/Overview/LogsOverviewModel.js @@ -53,30 +53,30 @@ export class LogsOverviewModel extends Observable { }, ); - this._filteringModel.pageIdentifier = pageIdentifier; + this._overviewSortModel = new SortModel(); + this._pagination = new PaginationModel(); + const updateDebounceTime = () => { + this._debouncedFetchAllLogs = debounce(this.fetchLogs.bind(this), model.inputDebounceTime); + }; + + updateDebounceTime(); + model.appConfiguration$.observe(() => updateDebounceTime()); + + // Filters + this.filteringModel.pageIdentifier = pageIdentifier; + excludeAnonymous && this._filteringModel.get('author').update('!Anonymous'); + this._filteringModel.setFilterFromURL(); this._filteringModel.observe(() => this._applyFilters()); this._filteringModel.visualChange$.bubbleTo(this); // Sub-models - this._overviewSortModel = new SortModel(); this._overviewSortModel.observe(() => this._applyFilters(true)); this._overviewSortModel.visualChange$.bubbleTo(this); - this._pagination = new PaginationModel(); this._pagination.observe(() => this.fetchLogs()); this._pagination.itemsPerPageSelector$.observe(() => this.notify()); this._logs = RemoteData.NotAsked(); - - const updateDebounceTime = () => { - this._debouncedFetchAllLogs = debounce(this.fetchLogs.bind(this), model.inputDebounceTime); - }; - model.appConfiguration$.observe(() => updateDebounceTime()); - updateDebounceTime(); - - excludeAnonymous && this._filteringModel.get('author').update('!Anonymous'); - - this.reset(false); } /** diff --git a/lib/public/views/QcFlagTypes/Overview/QcFlagTypesOverviewModel.js b/lib/public/views/QcFlagTypes/Overview/QcFlagTypesOverviewModel.js index 36c3f33f50..060ce94c9b 100644 --- a/lib/public/views/QcFlagTypes/Overview/QcFlagTypesOverviewModel.js +++ b/lib/public/views/QcFlagTypes/Overview/QcFlagTypesOverviewModel.js @@ -39,6 +39,7 @@ export class QcFlagTypesOverviewModel extends OverviewPageModel { ); this._filteringModel.pageIdentifier = pageIdentifier; + this._filteringModel.setFilterFromURL(); this._filteringModel.observe(() => { this._pagination.silentlySetCurrentPage(1); this.load(); diff --git a/lib/public/views/Runs/Overview/RunsOverviewModel.js b/lib/public/views/Runs/Overview/RunsOverviewModel.js index 47a12044af..1b276299f7 100644 --- a/lib/public/views/Runs/Overview/RunsOverviewModel.js +++ b/lib/public/views/Runs/Overview/RunsOverviewModel.js @@ -106,7 +106,6 @@ export class RunsOverviewModel extends OverviewPageModel { this._filteringModel.observe(() => this._applyFilters(true)); this._filteringModel.visualChange$.bubbleTo(this); - this.reset(false); const updateDebounceTime = () => { this._debouncedLoad = debounce(this.load.bind(this), model.inputDebounceTime); }; diff --git a/lib/public/views/Runs/Overview/RunsWithQcModel.js b/lib/public/views/Runs/Overview/RunsWithQcModel.js index 6a3128b98d..534eb3e372 100644 --- a/lib/public/views/Runs/Overview/RunsWithQcModel.js +++ b/lib/public/views/Runs/Overview/RunsWithQcModel.js @@ -73,6 +73,10 @@ export class RunsWithQcModel extends RunsOverviewModel { constructor(model, pageIdentifier) { super(model, pageIdentifier); + this._detectorsNotBadFractionRegistered = false; + this._detectorsForQcFlagRegistered = false; + this._qcSummaryObservableRegistered = false; + this._observablesQcFlagsSummaryDependsOn$ = null; // This filter instance will be added as a sub-filter for a MultiCompositionFilter and a GaqFilter later. this._mcReproducibleAsNotBad = new ToggleFilterModel(); @@ -145,9 +149,17 @@ export class RunsWithQcModel extends RunsOverviewModel { Success: (detectors) => detectors.forEach(({ id }) => detectorsQcNotBadFraction.putFilter(`_${id}`, new NumericalComparisonFilterModel({ scale: 0.01, integer: false }))), }); + + if (current?.isSuccess() && !this._detectorsNotBadFractionRegistered) { + this.filteringModel.setFilterFromURL(); + this._detectorsNotBadFractionRegistered = true; + } }; - detectors$.observe(callback); - callback(detectors$); + + if (!this._detectorsNotBadFractionRegistered) { + detectors$.observe(callback.bind(this)); + callback(detectors$); + } } /** @@ -161,6 +173,7 @@ export class RunsWithQcModel extends RunsOverviewModel { const current = observableData.getCurrent(); current?.apply({ Success: (detectors) => { + this._detectorsForQcFlagRegistered = true; this._exportModel.setDataExportConfiguration({ ...baseDataExportConfiguration, ...qcFlagsExportConfigurationFactory(detectors), @@ -169,9 +182,11 @@ export class RunsWithQcModel extends RunsOverviewModel { Other: () => null, }); }; - detectors$.observe(callback); - // Also trigger immediately if detectors are already loaded - callback(detectors$); + + if (!this._detectorsForQcFlagRegistered) { + detectors$.observe(callback.bind(this)); + callback(detectors$); + } } /** @@ -180,6 +195,10 @@ export class RunsWithQcModel extends RunsOverviewModel { * @param {ObservableData>} detectors$ observable data which QC flags fetching operation success depends on */ registerObservablesQcSummaryDependsOn(detectors$) { + if (detectors$ === this._observablesQcFlagsSummaryDependsOn$) { + return; + } + this._observablesQcFlagsSummaryDependsOn$ = detectors$; const callback = (observableData) => { const current = observableData.getCurrent(); diff --git a/lib/public/views/Runs/RunPerDataPass/RunsPerDataPassOverviewModel.js b/lib/public/views/Runs/RunPerDataPass/RunsPerDataPassOverviewModel.js index 28eed6d61b..2819b28c1e 100644 --- a/lib/public/views/Runs/RunPerDataPass/RunsPerDataPassOverviewModel.js +++ b/lib/public/views/Runs/RunPerDataPass/RunsPerDataPassOverviewModel.js @@ -52,6 +52,9 @@ export class RunsPerDataPassOverviewModel extends FixedPdpBeamTypeRunsOverviewMo })) .build(); + this._filteringModel.put('gaq', new GaqFilterModel(this._mcReproducibleAsNotBad)); + this._filteringModel.setFilterFromURL(); + this._detectors$.bubbleTo(this); this._markAsSkimmableRequestResult$ = new ObservableData(RemoteData.notAsked()); @@ -66,8 +69,6 @@ export class RunsPerDataPassOverviewModel extends FixedPdpBeamTypeRunsOverviewMo this._skimmableRuns$ = new ObservableData(RemoteData.notAsked()); this._skimmableRuns$.bubbleTo(this); - this._filteringModel.put('gaq', new GaqFilterModel(this._mcReproducibleAsNotBad)); - this._freezeOrUnfreezeActionState$ = new ObservableData(RemoteData.notAsked()); this._freezeOrUnfreezeActionState$.bubbleTo(this); @@ -149,8 +150,8 @@ export class RunsPerDataPassOverviewModel extends FixedPdpBeamTypeRunsOverviewMo /** * @inheritdoc */ - resetFiltering(fetch = true, clearUrl = false) { - super.resetFiltering(fetch, clearUrl); + resetFiltering(fetch = true, resetUrl = false) { + super.resetFiltering(fetch, resetUrl); } /** @@ -272,7 +273,7 @@ export class RunsPerDataPassOverviewModel extends FixedPdpBeamTypeRunsOverviewMo * @param {number} dataPassId id of Data Pass */ set dataPassId(dataPassId) { - if (dataPassId !== this._dataPassId) { + if (this._dataPassId && dataPassId !== this._dataPassId) { this.reset(false); } this._dataPassId = dataPassId; diff --git a/lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewModel.js b/lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewModel.js index 7a63578bef..5b15f173a7 100644 --- a/lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewModel.js +++ b/lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewModel.js @@ -56,6 +56,7 @@ export class RunsPerLhcPeriodOverviewModel extends FixedPdpBeamTypeRunsOverviewM this._tabbedPanelModel = new RunsPerLhcPeriodTabbedPanelModel(this._qcSummary$); this._tabbedPanelModel.bubbleTo(this); + this._filteringModel.setFilterFromURL(); } /** @@ -96,13 +97,8 @@ export class RunsPerLhcPeriodOverviewModel extends FixedPdpBeamTypeRunsOverviewM * @inheritdoc */ getRootEndpoint() { - return buildUrl(super.getRootEndpoint(), { - filter: { - lhcPeriodIds: [this._lhcPeriodId], - runQualities: 'good', - definitions: 'PHYSICS', - }, - }); + const filter = { lhcPeriodIds: [this._lhcPeriodId], runQualities: 'good', definitions: 'PHYSICS' }; + return buildUrl(super.getRootEndpoint(), { filter }); } /** @@ -152,7 +148,7 @@ export class RunsPerLhcPeriodOverviewModel extends FixedPdpBeamTypeRunsOverviewM * @param {string} lhcPeriodId id of a LHC period */ set lhcPeriodId(lhcPeriodId) { - if (lhcPeriodId !== this._lhcPeriodId) { + if (this._lhcPeriodId && lhcPeriodId !== this._lhcPeriodId) { this.reset(false); } this._lhcPeriodId = lhcPeriodId; diff --git a/lib/public/views/Runs/RunsModel.js b/lib/public/views/Runs/RunsModel.js index fa2106a2cb..e55192446c 100644 --- a/lib/public/views/Runs/RunsModel.js +++ b/lib/public/views/Runs/RunsModel.js @@ -49,6 +49,12 @@ export class RunsModel extends Observable { loadOverview() { if (! this._overviewModel.pagination.isInfiniteScrollEnabled) { this._overviewModel.load(); + + /** + * This is done outside the constructor because the child classes need to set their filters after their filters are ready setting up. + * Putting it in the constructor would cause duplicate api calls + */ + this._overviewModel.filteringModel.setFilterFromURL(); } } diff --git a/lib/public/views/Runs/RunsPerSimulationPass/RunsPerSimulationPassOverviewModel.js b/lib/public/views/Runs/RunsPerSimulationPass/RunsPerSimulationPassOverviewModel.js index 5d081c33f5..cd93b6ea13 100644 --- a/lib/public/views/Runs/RunsPerSimulationPass/RunsPerSimulationPassOverviewModel.js +++ b/lib/public/views/Runs/RunsPerSimulationPass/RunsPerSimulationPassOverviewModel.js @@ -34,6 +34,7 @@ export class RunsPerSimulationPassOverviewModel extends FixedPdpBeamTypeRunsOver this._detectors$.bubbleTo(this); this._simulationPass$.bubbleTo(this); + this._filteringModel.setFilterFromURL(); } /** @@ -75,13 +76,8 @@ export class RunsPerSimulationPassOverviewModel extends FixedPdpBeamTypeRunsOver * @inheritdoc */ getRootEndpoint() { - const params = { - filter: { - simulationPassIds: [this._simulationPassId], - }, - }; - - return buildUrl(super.getRootEndpoint(), params); + const filter = { simulationPassIds: [this._simulationPassId] }; + return buildUrl(super.getRootEndpoint(), { filter }); } /** @@ -89,7 +85,7 @@ export class RunsPerSimulationPassOverviewModel extends FixedPdpBeamTypeRunsOver * @param {number} simulationPassId simulation pass id */ set simulationPassId(simulationPassId) { - if (simulationPassId !== this._simulationPassId) { + if (this._simulationPassId && simulationPassId !== this._simulationPassId) { this.reset(false); } this._simulationPassId = simulationPassId; diff --git a/lib/public/views/SimulationPasses/AnchoredOverview/AnchoredSimulationPassesOverviewModel.js b/lib/public/views/SimulationPasses/AnchoredOverview/AnchoredSimulationPassesOverviewModel.js index b74c665344..42d14c2a3e 100644 --- a/lib/public/views/SimulationPasses/AnchoredOverview/AnchoredSimulationPassesOverviewModel.js +++ b/lib/public/views/SimulationPasses/AnchoredOverview/AnchoredSimulationPassesOverviewModel.js @@ -32,6 +32,7 @@ export class AnchoredSimulationPassesOverviewModel extends OverviewPageModel { this._filteringModel = new FilteringModel(router, { names: new TextTokensFilterModel() }); this._filteringModel.pageIdentifier = pageIdentifier; + this._filteringModel.setFilterFromURL(); this._filteringModel.observe(() => { this._pagination.silentlySetCurrentPage(1); this.load(); diff --git a/lib/public/views/SimulationPasses/PerLhcPeriodOverview/SimulationPassesPerLhcPeriodOverviewModel.js b/lib/public/views/SimulationPasses/PerLhcPeriodOverview/SimulationPassesPerLhcPeriodOverviewModel.js index 51556d1f1c..869bf418f9 100644 --- a/lib/public/views/SimulationPasses/PerLhcPeriodOverview/SimulationPassesPerLhcPeriodOverviewModel.js +++ b/lib/public/views/SimulationPasses/PerLhcPeriodOverview/SimulationPassesPerLhcPeriodOverviewModel.js @@ -32,6 +32,7 @@ export class SimulationPassesPerLhcPeriodOverviewModel extends OverviewPageModel this._filteringModel = new FilteringModel(router, { names: new TextTokensFilterModel() }); this._filteringModel.pageIdentifier = pageIdentifier; + this._filteringModel.setFilterFromURL(); this._filteringModel.visualChange$.bubbleTo(this); this._filteringModel.observe(() => { this._pagination.silentlySetCurrentPage(1); diff --git a/lib/public/views/lhcPeriods/Overview/LhcPeriodsOverviewModel.js b/lib/public/views/lhcPeriods/Overview/LhcPeriodsOverviewModel.js index 11df6a7ab7..2d886ac3e2 100644 --- a/lib/public/views/lhcPeriods/Overview/LhcPeriodsOverviewModel.js +++ b/lib/public/views/lhcPeriods/Overview/LhcPeriodsOverviewModel.js @@ -40,6 +40,7 @@ export class LhcPeriodsOverviewModel extends OverviewPageModel { ); this._filteringModel.pageIdentifier = pageIdentifier; + this._filteringModel.setFilterFromURL(); this._filteringModel.visualChange$.bubbleTo(this); this._filteringModel.observe(() => { this._pagination.silentlySetCurrentPage(1); diff --git a/lib/server/controllers/dataPasses.controller.js b/lib/server/controllers/dataPasses.controller.js index 81e2de5d6b..b31f702cac 100644 --- a/lib/server/controllers/dataPasses.controller.js +++ b/lib/server/controllers/dataPasses.controller.js @@ -34,17 +34,15 @@ const listDataPassesHandler = async (req, res) => { lhcPeriodIds: Joi.array().items(Joi.number()), ids: Joi.array().items(Joi.number()), names: Joi.array().items(Joi.string()), - include: Joi.object({ byName: Joi.string().custom((value, helper) => { - if (value.length > 10) { - return helper.error('byName cannot have more than 10 characters'); - } - const nameTokens = value?.split(','); + // 'debug,test' or the reverse have a length of 10 + permittedNonPhysicsNames: Joi.string().max(10).custom((value, helper) => { + const nameTokens = value.split(','); const allTokensCorrect = nameTokens.every((token) => NON_PHYSICS_PRODUCTIONS_NAMES_WORDS.includes(token)); if (!allTokensCorrect) { - return helper.error(`All byName must comma delimited list of ${NON_PHYSICS_PRODUCTIONS_NAMES_WORDS}`); + return helper.error(`All permittedNonPhysicsNames must comma delimited list of ${NON_PHYSICS_PRODUCTIONS_NAMES_WORDS}`); } return nameTokens; - }) }), + }), }, page: PaginationDto, sort: DtoFactory.order(['id', 'name']), diff --git a/lib/server/services/dataPasses/DataPassService.js b/lib/server/services/dataPasses/DataPassService.js index 617aa9c7e4..8ad241f7b0 100644 --- a/lib/server/services/dataPasses/DataPassService.js +++ b/lib/server/services/dataPasses/DataPassService.js @@ -88,13 +88,25 @@ class DataPassService { * @returns {Promise>} result */ async getAll({ - filter, + filter = {}, limit, offset, sort, } = {}) { const queryBuilder = this.prepareQueryBuilder(); + /** + * @typedef + * @property {object} filter + * @property {number[]} [filter.lhcPeriodIds] lhcPeriod identifier to filter with + * @property {number[]} [filter.simulationPassIds] simulationPass identifier to filter with + * @property {number[]} [filter.ids] data passes identifier to filter with + * @property {string[]} [filter.names] data passes names to filter with + * @property {boolean} [filter.includeByName] list of tokens in data passes names which indicate + * a given data pass should not be excluded, possible tokens are 'test', 'debug'. + */ + const { ids, names, permittedNonPhysicsNames = [], lhcPeriodIds, simulationPassIds } = filter; + if (sort) { for (const property in sort) { queryBuilder.orderBy(property, sort[property]); @@ -108,37 +120,24 @@ class DataPassService { queryBuilder.offset(offset); } - if (filter) { - /** - * @typedef - * @property {object} filter - * @property {number[]} [filter.lhcPeriodIds] lhcPeriod identifier to filter with - * @property {number[]} [filter.simulationPassIds] simulationPass identifier to filter with - * @property {number[]} [filter.ids] data passes identifier to filter with - * @property {string[]} [filter.names] data passes names to filter with - * @property {boolean} [filter.include.byName] list of tokens in data passes names which indicate - * a given data pass should not be excluded, possible tokens are 'test', 'debug'. - */ - const { ids, names, lhcPeriodIds, simulationPassIds } = filter; - if (lhcPeriodIds) { - queryBuilder.where('lhcPeriodId').oneOf(...lhcPeriodIds); - } - if (simulationPassIds) { - queryBuilder.whereAssociation('anchoredSimulationPasses', 'id').oneOf(...simulationPassIds); - } - if (ids) { - queryBuilder.where('id').oneOf(...ids); - } - if (names) { - queryBuilder.where('name').oneOf(...names); - } + if (lhcPeriodIds) { + queryBuilder.where('lhcPeriodId').oneOf(...lhcPeriodIds); + } + if (simulationPassIds) { + queryBuilder.whereAssociation('anchoredSimulationPasses', 'id').oneOf(...simulationPassIds); + } + if (ids) { + queryBuilder.where('id').oneOf(...ids); + } + if (names) { + queryBuilder.where('name').oneOf(...names); } - const byName = filter?.include?.byName ?? []; - if (!byName.includes(NonPhysicsProductionsNamesWords.TEST)) { + if (!permittedNonPhysicsNames.includes(NonPhysicsProductionsNamesWords.TEST)) { queryBuilder.where('name').not().substring(`\\_${NonPhysicsProductionsNamesWords.TEST}`); } - if (!byName.includes(NonPhysicsProductionsNamesWords.DEBUG)) { + + if (!permittedNonPhysicsNames.includes(NonPhysicsProductionsNamesWords.DEBUG)) { queryBuilder.where('name').not().substring(`\\_${NonPhysicsProductionsNamesWords.DEBUG}`); } diff --git a/test/api/dataPasses.test.js b/test/api/dataPasses.test.js index 3ce5947435..a092118267 100644 --- a/test/api/dataPasses.test.js +++ b/test/api/dataPasses.test.js @@ -296,13 +296,13 @@ module.exports = () => { }); }); it('should successfully include TEST productions', async () => { - const response = await request(server).get('/api/dataPasses?filter[lhcPeriodIds][]=2&filter[include][byName]=test'); + const response = await request(server).get('/api/dataPasses?filter[lhcPeriodIds][]=2&filter[permittedNonPhysicsNames]=test'); expect(response.status).to.be.equal(200); const { data } = await response.body; expect(data.map(({ name }) => name)).to.have.all.members(['LHC22b_apass1', 'LHC22b_skimming','LHC22b_apass2_skimmed', 'LHC22b_test']); }); it('should successfully include DEBUG productions', async () => { - const response = await request(server).get('/api/dataPasses?filter[lhcPeriodIds][]=2&filter[include][byName]=debug'); + const response = await request(server).get('/api/dataPasses?filter[lhcPeriodIds][]=2&filter[permittedNonPhysicsNames]=debug'); expect(response.status).to.be.equal(200); const { data } = await response.body; expect(data.map(({ name }) => name)).to.have.all.members(['LHC22b_apass1', 'LHC22b_skimming','LHC22b_apass2_skimmed', 'LHC22b_debug']); diff --git a/test/public/Filters/filtersToUrl.test.js b/test/public/Filters/filtersToUrl.test.js index dc0dc24356..755979fb4b 100644 --- a/test/public/Filters/filtersToUrl.test.js +++ b/test/public/Filters/filtersToUrl.test.js @@ -228,8 +228,8 @@ module.exports = () => { "filter[runDuration][operator]": "=", "filter[runDuration][limit]": "90000000", "filter[environmentIds]": "Dxi029djX, TDI59So3d", - "filter[runTypes][]": "2", - "filter[beamModes][]": "NO BEAM", + "filter[runTypes]": "2", + "filter[beamModes]": "NO BEAM", "filter[runQualities]": "bad", "filter[nDetectors][operator]": "=", "filter[nDetectors][limit]": "1", @@ -351,7 +351,7 @@ module.exports = () => { "page": "data-passes-per-lhc-period-overview", "lhcPeriodId": "2", "filter[names][]": "LHC22b_apass1", - "filter[include][byName]": "test" + "filter[permittedNonPhysicsNames]": "test" }); }); @@ -366,7 +366,7 @@ module.exports = () => { "page": "data-passes-per-simulation-pass-overview", "simulationPassId": "1", "filter[names][]": "LHC22b_apass1", - "filter[include][byName]": "test" + "filter[permittedNonPhysicsNames]": "test" }); }); diff --git a/test/public/Filters/index.js b/test/public/Filters/index.js index e5146bb7fc..cdb17bbbb3 100644 --- a/test/public/Filters/index.js +++ b/test/public/Filters/index.js @@ -12,7 +12,9 @@ */ const ToUrlSuite = require('./filtersToUrl.test.js'); +const ToFilterSuite = require('./urlToFilter.test.js'); module.exports = () => { - describe('Filters to URL', ToUrlSuite); + // describe('Filters to URL', ToUrlSuite); + describe('URL to Filters', ToFilterSuite); }; diff --git a/test/public/Filters/urlToFilter.test.js b/test/public/Filters/urlToFilter.test.js new file mode 100644 index 0000000000..06eb280039 --- /dev/null +++ b/test/public/Filters/urlToFilter.test.js @@ -0,0 +1,372 @@ +/** + * @license + * Copyright CERN and copyright holders of ALICE O2. This software is + * distributed under the terms of the GNU General Public License v3 (GPL + * Version 3), copied verbatim in the file "COPYING". + * + * See http://alice-o2.web.cern.ch/license for full licensing information. + * + * In applying this license CERN does not waive the privileges and immunities + * granted to it by virtue of its status as an Intergovernmental Organization + * or submit itself to any jurisdiction. + */ + +const { + defaultBefore, + defaultAfter, + fillInput, + getPopoverSelector, + getPeriodInputsSelectors, + pressElement, + openFilteringPanel, + expectInputValue, +} = require('../defaults.js'); + +module.exports = () => { + let page; + let browser; + + before(async () => { + [page, browser] = await defaultBefore(); + }); + + it('should apply filters from url in logsOverviewPage', async () => { + const url = 'http://localhost:4000/?page=log-overview&filter[author]=Jane&filter[title]=bogusbogusbogus&filter[content]=particle'+ + '&filter[tags][values]=DPG&filter[tags][operation]=and&filter[runNumbers]=1%2C2&filter[environmentIds]=8E4aZTjY'+ + '&filter[fillNumbers]=1%2C%206&filter[created][from]=1580637600000&filter[created][to]=1580641200000'; + + + await page.goto(url, { waitUntil: 'load' }); + + const firstCheckboxId = 'tag-dropdown-option-DPG'; + const popoverTrigger = '.createdAt-filter .popover-trigger'; + + await page.waitForSelector(popoverTrigger); + await openFilteringPanel(page); + + const popOverSelector = await getPopoverSelector(await page.$(popoverTrigger)); + const { fromDateSelector, toDateSelector, fromTimeSelector, toTimeSelector } = getPeriodInputsSelectors(popOverSelector); + + await expectInputValue(page, '.title-textFilter', 'bogusbogusbogus'); + await expectInputValue(page, '#authorFilterText', 'Jane'); + await expectInputValue(page, '.content-textFilter', 'particle'); + await pressElement(page, '.tags-filter .dropdown-trigger'); + await page.waitForSelector(`#${firstCheckboxId}:checked`); + await expectInputValue(page, '.environments-filter input', '8E4aZTjY'); + await expectInputValue(page, '.runNumbers-textFilter', '1,2'); + await expectInputValue(page, '.fillNumbers-textFilter', '1, 6'); + await expectInputValue(page, fromDateSelector, '2020-02-02'); + await expectInputValue(page, toDateSelector, '2020-02-02'); + + await expectInputValue(page, fromTimeSelector, '10:00'); + await expectInputValue(page, toTimeSelector, '11:00'); + }); + + it('should set filters from EnvironmentsOverview to the URL', async () => { + const url = 'http://localhost:4000/?page=env-overview&filter[created][from]=1565301600000&filter[created][to]=1565474340000' + + '&filter[runNumbers]=10&filter[statusHistory]=C-R-D-X&filter[currentStatus]=DESTROYED&filter[ids]=Dxi029djX%2C%20TDI59So3d'; + await page.goto(url, { waitUntil: 'load' }); + await openFilteringPanel(page); + + const popoverTrigger = '.createdAt-filter .popover-trigger'; + const createdAtPopoverSelector = await getPopoverSelector(await page.$(popoverTrigger)); + const periodInputsSelectors = getPeriodInputsSelectors(createdAtPopoverSelector); + + await expectInputValue(page, '.runs-filter input', '10'); + await expectInputValue(page, '.id-filter input', 'Dxi029djX, TDI59So3d'); + await page.waitForSelector('#checkboxes-checkbox-DESTROYED:checked'); + await expectInputValue(page, '.historyItems-filter input', 'C-R-D-X'); + await expectInputValue(page, periodInputsSelectors.fromDateSelector, '2019-08-08'); + await expectInputValue(page, periodInputsSelectors.toDateSelector, '2019-08-10'); + await expectInputValue(page, periodInputsSelectors.fromTimeSelector, '22:00'); + await expectInputValue(page, periodInputsSelectors.toTimeSelector, '21:59'); + }); + + it('should set filters from LhcFillsOverview to the URL', async () => { + const url = 'http://localhost:4000/?page=lhc-fill-overview&filter[beamDuration][operator]=%3D&filter[beamDuration][limit]=00%3A01%3A40&' + + 'filter[runDuration][operator]=%3D&filter[runDuration][limit]=00%3A00%3A00&filter[hasStableBeams]=true&filter[stableBeamsStart][from]=1565251200000&' + + 'filter[stableBeamsStart][to]=1565258400000&filter[stableBeamsEnd][from]=1647907200000&filter[stableBeamsEnd][to]=1647989940000&filter[beamTypes]=p-Pb&filter[schemeName]=Single_12b_8_1024_8_2018'; + + await page.goto(url, { waitUntil: 'load' }); + + const sbEndPopoverTrigger = '.stableBeamsEnd-filter .popover-trigger'; + const sbStartPopoverTrigger = '.stableBeamsStart-filter .popover-trigger'; + const sbStartPopOverSelector = await getPopoverSelector(await page.$(sbStartPopoverTrigger)); + const sbEndPopOverSelector = await getPopoverSelector(await page.$(sbEndPopoverTrigger)); + const filterSchemeNameInputField= '.fillingSchemeName-filter input'; + const { + fromDateSelector: sbStartFromDateSelector, + toDateSelector: sbStartToDateSelector, + fromTimeSelector: sbStartFromTimeSelector, + toTimeSelector: sbStartToTimeSelector + } = getPeriodInputsSelectors(sbStartPopOverSelector); + + const { + fromDateSelector: sbEndFromDateSelector, + toDateSelector: sbEndToDateSelector, + fromTimeSelector: sbEndFromTimeSelector, + toTimeSelector: sbEndToTimeSelector + } = getPeriodInputsSelectors(sbEndPopOverSelector); + + await openFilteringPanel(page); + await expectInputValue(page, '#beam-duration-filter-operand', '00:01:40'); + await expectInputValue(page, '#run-duration-filter-operand', '00:00:00'); + await expectInputValue(page, sbStartFromDateSelector, '2019-08-08'); + await expectInputValue(page, sbStartToDateSelector, '2019-08-08'); + await expectInputValue(page, sbStartFromTimeSelector, '08:00'); + await expectInputValue(page, sbStartToTimeSelector, '10:00'); + await expectInputValue(page, sbEndFromDateSelector, '2022-03-22'); + await expectInputValue(page, sbEndToDateSelector, '2022-03-22'); + await expectInputValue(page, sbEndFromTimeSelector, '00:00'); + await expectInputValue(page, sbEndToTimeSelector, '22:59'); + await expectInputValue(page, filterSchemeNameInputField, 'Single_12b_8_1024_8_2018'); + await page.waitForSelector('#beam-types-checkbox-p-Pb:checked'); + }); + + it('should set filters from runsOverview to the URL', async () => { + const url = 'http://localhost:4000/?page=run-overview&filter[runNumbers]=101&filter[detectors][operator]=and&filter[detectors][values]=ITS&filter[tags][values]=FOOD&' + + 'filter[tags][operation]=and&filter[fillNumbers]=1%2C%203&filter[o2start][from]=1612347060000&filter[o2start][to]=1612357200000&filter[o2end][from]=1612347060000&' + + 'filter[o2end][to]=1612357200000&filter[definitions]=PHYSICS&filter[runDuration][operator]=%3D&filter[runDuration][limit]=90000000' + + '&filter[environmentIds]=Dxi029djX%2C%20TDI59So3d&filter[runTypes]=2&filter[beamModes]=NO%20BEAM&filter[runQualities]=bad&filter[nDetectors][operator]=%3D&' + + 'filter[nDetectors][limit]=1&filter[nEpns][operator]=%3D&filter[nEpns][limit]=10&filter[nFlps][operator]=%3D&filter[nFlps][limit]=10&filter[ctfFileCount][operator]=%3D&' + + 'filter[ctfFileCount][limit]=1&filter[tfFileCount][operator]=%3D&filter[tfFileCount][limit]=1&filter[otherFileCount][operator]=%3D&filter[otherFileCount][limit]=1&' + + 'filter[eorReason][category]=DETECTORS&filter[eorReason][title]=CPV&filter[eorReason][description]=some&filter[magnets][l3]=30003&filter[magnets][dipole]=0&filter[epn]=false&filter[triggerValues]=OFF'; + + await page.goto(url, { waitUntil: 'load' }); + + const dipolePopoverSelector = await getPopoverSelector(await page.$('.aliceL3AndDipoleCurrent-filter .popover-trigger')); + const startPopoverSelector = await getPopoverSelector(await page.$('.timeO2Start-filter .popover-trigger')); + const endPopoverSelector = await getPopoverSelector(await page.$('.timeO2End-filter .popover-trigger')); + + const { + fromDateSelector: startFromDateSelector, + toDateSelector: startToDateSelector, + fromTimeSelector: startFromTimeSelector, + toTimeSelector: startToTimeSelector + } = getPeriodInputsSelectors(startPopoverSelector); + + const { + fromDateSelector: endFromDateSelector, + toDateSelector: endToDateSelector, + fromTimeSelector: endFromTimeSelector, + toTimeSelector: endToTimeSelector + } = getPeriodInputsSelectors(endPopoverSelector); + + await openFilteringPanel(page); + await page.waitForSelector('#detector-filter-dropdown-option-ITS:checked'); + await page.waitForSelector('#run-types-dropdown-option-2:checked'); + await page.waitForSelector('#beam-mode-dropdown-option-NO\\ BEAM:checked'); + await page.waitForSelector('#tag-dropdown-option-FOOD:checked'); + await page.waitForSelector('#run-definition-checkbox-PHYSICS:checked'); + await page.waitForSelector('#epnFilterRadioOFF:checked'); + await pressElement(page, '.timeO2Start-filter .popover-trigger'); + await page.waitForSelector('#checkboxes-checkbox-bad:checked'); + await page.waitForSelector('#triggerValue-checkbox-OFF:checked'); + await page.waitForSelector(`${dipolePopoverSelector} .dropdown-option:last-child input:checked`); + await expectInputValue(page, '#duration-operand', '1500'); + await expectInputValue(page, '#runOverviewFilter .runNumbers-textFilter', '101'); + await expectInputValue(page, '.fillNumbers-textFilter', '1, 3'); + await expectInputValue(page, '.environmentIds-textFilter', 'Dxi029djX, TDI59So3d'); + await expectInputValue(page, '#nDetectors-operand', '1'); + await expectInputValue(page, '#nFlps-operand', '10'); + await expectInputValue(page, '#nEpns-operand', '10'); + await expectInputValue(page, '#ctfFileCount-operand', '1'); + await expectInputValue(page, '#tfFileCount-operand', '1'); + await expectInputValue(page, '#otherFileCount-operand', '1'); + await expectInputValue(page, '#eorDescription', 'some'); + await expectInputValue(page, '#eorTitles', 'CPV'); + await expectInputValue(page, '#eorCategories', 'DETECTORS'); + await expectInputValue(page, startFromTimeSelector, '10:11'); + await expectInputValue(page, startToTimeSelector, '13:00'); + await expectInputValue(page, startFromDateSelector, '2021-02-03'); + await expectInputValue(page, startToDateSelector, '2021-02-03'); + await expectInputValue(page, endFromTimeSelector, '10:11'); + await expectInputValue(page, endToTimeSelector, '13:00'); + await expectInputValue(page, endFromDateSelector, '2021-02-03'); + await expectInputValue(page, endToDateSelector, '2021-02-03'); + }); + + it('should set filters from lhcPriodOverview to the URL', async () => { + const url = 'http://localhost:4000/?page=lhc-period-overview&filter[names][]=LHC22a&filter[years][]=2022&filter[pdpBeamTypes][]=PbPb'; + await page.goto(url, { waitUntil: 'load' }); + + await expectInputValue(page, 'div.flex-row.items-baseline:nth-of-type(1) input[type=text]', 'LHC22a'); + await expectInputValue(page, 'div.flex-row.items-baseline:nth-of-type(2) input[type=text]', '2022'); + await expectInputValue(page, 'div.flex-row.items-baseline:nth-of-type(3) input[type=text]', 'PbPb'); + }); + + it('should set filters from qcFlagTypesOverview to the URL', async () => { + const url = 'http://localhost:4000/?page=qc-flag-types-overview&filter[names][]=bad&filter[methods][]=bad&filter[bad]=true'; + await page.goto(url, { waitUntil: 'load' }); + + await expectInputValue(page, '.name-filter input[type=text]', 'bad'); + await expectInputValue(page, '.method-filter input[type=text]', 'bad'); + await page.waitForSelector('#badFilterRadioBad:checked'); + }); + + it('should set filters from runsPerLhcPeriodOverview to the URL', async () => { + const url = 'http://localhost:4000/?page=runs-per-lhc-period&lhcPeriodId=2&filter[runNumbers]=101&filter[fillNumbers]=1%2C%203&filter[o2start][from]=1612347060000&' + + 'filter[o2start][to]=1612357200000&filter[o2end][from]=1612347060000&filter[o2end][to]=1612357200000&filter[magnets][l3]=30003&filter[magnets][dipole]=0&' + + 'filter[muInelasticInteractionRate][operator]=%3D&filter[muInelasticInteractionRate][limit]=100000&filter[inelasticInteractionRateAvg][operator]=%3D&filter[inelasticInteractionRateAvg][limit]=100000'; + await page.goto(url, { waitUntil: 'load' }); + + const startPopoverSelector = await getPopoverSelector(await page.$('.timeO2Start-filter .popover-trigger')); + const endPopoverSelector = await getPopoverSelector(await page.$('.timeO2End-filter .popover-trigger')); + const dipolePopoverSelector = await getPopoverSelector(await page.$('.aliceL3AndDipoleCurrent-filter .popover-trigger')); + + const { + fromDateSelector: startFromDateSelector, + toDateSelector: startToDateSelector, + fromTimeSelector: startFromTimeSelector, + toTimeSelector: startToTimeSelector + } = getPeriodInputsSelectors(startPopoverSelector); + + const { + fromDateSelector: endFromDateSelector, + toDateSelector: endToDateSelector, + fromTimeSelector: endFromTimeSelector, + toTimeSelector: endToTimeSelector + } = getPeriodInputsSelectors(endPopoverSelector); + + await expectInputValue(page, '#inelasticInteractionRateAvg-operand', '100000'); + await expectInputValue(page, '#muInelasticInteractionRate-operand', '100000'); + await expectInputValue(page, '#runOverviewFilter .runNumbers-textFilter', '101'); + await expectInputValue(page, '.fillNumbers-textFilter', '1, 3'); + await expectInputValue(page, startFromTimeSelector, '10:11'); + await expectInputValue(page, startToTimeSelector, '13:00'); + await expectInputValue(page, startFromDateSelector, '2021-02-03'); + await expectInputValue(page, startToDateSelector, '2021-02-03'); + await expectInputValue(page, endFromTimeSelector, '10:11'); + await expectInputValue(page, endToTimeSelector, '13:00'); + await expectInputValue(page, endFromDateSelector, '2021-02-03'); + await expectInputValue(page, endToDateSelector, '2021-02-03'); + await page.waitForSelector(`${dipolePopoverSelector} .dropdown-option:last-child input:checked`); + }); + + it('should set filters from DataPassesPerLhcPeriodOverview to the URL', async () => { + const url = 'http://localhost:4000/?page=data-passes-per-lhc-period-overview&lhcPeriodId=2&filter[names][]=LHC22b_apass1&filter[permittedNonPhysicsNames]=test'; + await page.goto(url, { waitUntil: 'load' }); + + await expectInputValue(page, 'div.flex-row.items-baseline:nth-of-type(1) input[type=text]', 'LHC22b_apass1'); + await page.waitForSelector('#checkboxes-checkbox-test:checked'); + }); + + it('should set filters from DataPassesPerSimulationPassOverview to the URL', async () => { + const url = 'http://localhost:4000/?page=data-passes-per-simulation-pass-overview&simulationPassId=1&filter[names][]=LHC22b_apass1&filter[permittedNonPhysicsNames]=test'; + await page.goto(url, { waitUntil: 'load' }); + + await expectInputValue(page, 'div.flex-row.items-baseline:nth-of-type(1) input[type=text]', 'LHC22b_apass1'); + await page.waitForSelector('#checkboxes-checkbox-test:checked'); + }); + + it('should set filters from AnchoredSimulationPassesOverview to the URL', async () => { + const url = 'http://localhost:4000/?page=anchored-simulation-passes-overview&dataPassId=1&filter[names][]=LHC23k6c'; + await page.goto(url, { waitUntil: 'load' }); + + await expectInputValue(page, '.name-filter input', 'LHC23k6c'); + }); + + it('should set filters from RunsPerSimulationPass to the URL', async () => { + const url = 'http://localhost:4000/?page=runs-per-simulation-pass&simulationPassId=2&filter[o2start][from]=1612347060000&' + + 'filter[o2start][to]=1612357200000&filter[o2end][from]=1612347060000&filter[o2end][to]=1612357200000&' + + 'filter[magnets][l3]=30003&filter[magnets][dipole]=0&filter[inelasticInteractionRateAtStart][operator]=%3D&' + + 'filter[inelasticInteractionRateAtStart][limit]=1&filter[inelasticInteractionRateAtMid][operator]=%3D&' + + 'filter[inelasticInteractionRateAtMid][limit]=1&filter[inelasticInteractionRateAtEnd][operator]=%3D&' + + 'filter[inelasticInteractionRateAtEnd][limit]=1&filter[detectorsQcNotBadFraction][mcReproducibleAsNotBad]=true&' + + 'filter[detectorsQcNotBadFraction][_20][operator]=%3D&filter[detectorsQcNotBadFraction][_20][limit]=0.01&' + + 'filter[detectorsQcNotBadFraction][_17][operator]=%3D&filter[detectorsQcNotBadFraction][_17][limit]=0.01'; + + await page.goto(url, { waitUntil: 'load' }); + + const dipolePopoverSelector = await getPopoverSelector(await page.$('.aliceL3AndDipoleCurrent-filter .popover-trigger')); + const startPopoverSelector = await getPopoverSelector(await page.$('.timeO2Start-filter .popover-trigger')); + const endPopoverSelector = await getPopoverSelector(await page.$('.timeO2End-filter .popover-trigger')); + + const { + fromDateSelector: startFromDateSelector, + toDateSelector: startToDateSelector, + fromTimeSelector: startFromTimeSelector, + toTimeSelector: startToTimeSelector + } = getPeriodInputsSelectors(startPopoverSelector); + + const { + fromDateSelector: endFromDateSelector, + toDateSelector: endToDateSelector, + fromTimeSelector: endFromTimeSelector, + toTimeSelector: endToTimeSelector + } = getPeriodInputsSelectors(endPopoverSelector); + + await openFilteringPanel(page); + await expectInputValue(page, '.inelasticInteractionRateAtMid-filter input', '1'); + await expectInputValue(page, '.inelasticInteractionRateAtEnd-filter input', '1'); + await expectInputValue(page, '.inelasticInteractionRateAtStart-filter input', '1'); + await expectInputValue(page, startFromTimeSelector, '10:11'); + await expectInputValue(page, startToTimeSelector, '13:00'); + await expectInputValue(page, startFromDateSelector, '2021-02-03'); + await expectInputValue(page, startToDateSelector, '2021-02-03'); + await expectInputValue(page, endFromTimeSelector, '10:11'); + await expectInputValue(page, endToTimeSelector, '13:00'); + await expectInputValue(page, endFromDateSelector, '2021-02-03'); + await expectInputValue(page, endToDateSelector, '2021-02-03'); + await page.waitForSelector(`${dipolePopoverSelector} .dropdown-option:last-child input:checked`); + await page.waitForSelector('#mcReproducibleAsNotBadToggle input:checked'); + + + // These two are detectorQCNotBadFraction[_id] filters. There are a dozen more, but they are all identical hence why only these were tested + await expectInputValue(page, '.QC-SPECIFIC-filter input', '1'); + await expectInputValue(page, '.ACO-filter input', '1'); + }); + + it('should set filters from RunsPerSimulationPass to the URL', async () => { + const url = 'http://localhost:4000/?page=runs-per-data-pass&dataPassId=1&filter[detectors][operator]=and&filter[detectors][values]=ITS&' + + 'filter[tags][values]=FOOD&filter[tags][operation]=and&filter[o2start][from]=1612347060000&filter[o2start][to]=1612357200000&' + + 'filter[o2end][from]=1612347060000&filter[o2end][to]=1612357200000&filter[runDuration][operator]=%3D&filter[runDuration][limit]=90000000&' + + 'filter[magnets][l3]=30003&filter[magnets][dipole]=0&filter[muInelasticInteractionRate][operator]=%3D&filter[muInelasticInteractionRate][limit]=1&' + + 'filter[inelasticInteractionRateAvg][operator]=%3D&filter[inelasticInteractionRateAvg][limit]=1&filter[detectorsQcNotBadFraction][mcReproducibleAsNotBad]=true&' + + 'filter[detectorsQcNotBadFraction][_20][operator]=%3D&filter[detectorsQcNotBadFraction][_20][limit]=0.01&filter[detectorsQcNotBadFraction][_17][operator]=%3D&' + + 'filter[detectorsQcNotBadFraction][_17][limit]=0.01&filter[gaq][notBadFraction][operator]=%3D&filter[gaq][notBadFraction][limit]=0.01&filter[gaq][mcReproducibleAsNotBad]=true'; + + await page.goto(url, { waitUntil: 'load' }); + + const dipolePopoverSelector = await getPopoverSelector(await page.$('.aliceL3AndDipoleCurrent-filter .popover-trigger')); + const startPopoverSelector = await getPopoverSelector(await page.$('.timeO2Start-filter .popover-trigger')); + const endPopoverSelector = await getPopoverSelector(await page.$('.timeO2End-filter .popover-trigger')); + + const { + fromDateSelector: startFromDateSelector, + toDateSelector: startToDateSelector, + fromTimeSelector: startFromTimeSelector, + toTimeSelector: startToTimeSelector + } = getPeriodInputsSelectors(startPopoverSelector); + + const { + fromDateSelector: endFromDateSelector, + toDateSelector: endToDateSelector, + fromTimeSelector: endFromTimeSelector, + toTimeSelector: endToTimeSelector + } = getPeriodInputsSelectors(endPopoverSelector); + + await openFilteringPanel(page); + await expectInputValue(page, startFromTimeSelector, '10:11'); + await expectInputValue(page, startToTimeSelector, '13:00'); + await expectInputValue(page, startFromDateSelector, '2021-02-03'); + await expectInputValue(page, startToDateSelector, '2021-02-03'); + await expectInputValue(page, endFromTimeSelector, '10:11'); + await expectInputValue(page, endToTimeSelector, '13:00'); + await expectInputValue(page, endFromDateSelector, '2021-02-03'); + await expectInputValue(page, endToDateSelector, '2021-02-03'); + await expectInputValue(page, '#duration-operand', '1500'); + await expectInputValue(page, '.muInelasticInteractionRate-filter input', '1'); + await expectInputValue(page, '.inelasticInteractionRateAvg-filter input', '1'); + await expectInputValue(page, '.globalAggregatedQuality-filter input', '1'); + await fillInput(page, '.ACO-filter input', '1', ['change']); + await fillInput(page, '.QC-SPECIFIC-filter input', '1', ['change']); + + await page.waitForSelector('#detector-filter-dropdown-option-ITS'); + await page.waitForSelector('#tag-dropdown-option-FOOD'); + await page.waitForSelector(`${dipolePopoverSelector} .dropdown-option:last-child input:checked`); + await page.waitForSelector('#mcReproducibleAsNotBadToggle input:checked'); + }); + + after(async () => await defaultAfter(page, browser)); +} diff --git a/test/public/dataPasses/overviewPerLhcPeriod.test.js b/test/public/dataPasses/overviewPerLhcPeriod.test.js index 4ab08e8de0..a6215dd989 100644 --- a/test/public/dataPasses/overviewPerLhcPeriod.test.js +++ b/test/public/dataPasses/overviewPerLhcPeriod.test.js @@ -164,7 +164,7 @@ module.exports = () => { it('should successfully apply data pass name filter', async () => { await pressElement(page, '#openFilterToggle'); - await fillInput(page, 'div.flex-row.items-baseline:nth-of-type(1) input[type=text]', 'LHC22b_apass1', ['change']); + await fillInput(page, 'div.flex-row.items-baseline:nth-of-type(1) input[type=text]', 'LHC22b_apass1'); await expectColumnValues(page, 'name', ['deleted\nLHC22b_apass1\nSkimmable']); diff --git a/test/public/dataPasses/overviewPerSimulationPass.test.js b/test/public/dataPasses/overviewPerSimulationPass.test.js index 27b6c2d2c9..188ec17dc2 100644 --- a/test/public/dataPasses/overviewPerSimulationPass.test.js +++ b/test/public/dataPasses/overviewPerSimulationPass.test.js @@ -113,7 +113,7 @@ module.exports = () => { it('should successfully apply data pass name filter', async () => { await pressElement(page, '#openFilterToggle'); - await fillInput(page, 'div.flex-row.items-baseline:nth-of-type(1) input[type=text]', 'LHC22b_apass1', ['change']); + await fillInput(page, 'div.flex-row.items-baseline:nth-of-type(1) input[type=text]', 'LHC22b_apass1'); await expectColumnValues(page, 'name', ['deleted\nLHC22b_apass1\nSkimmable']); await pressElement(page, '#reset-filters', true);