align

Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>

Author: f3sch

Detectors/Upgrades/ITS3/alignment/include/ITS3Align/AlignmentTypes.h

@@ -48,7 +48,7 @@ struct FrameInfoExt final {
 struct FitInfo final {
   float chi2Ndf{-1}; // Chi2/Ndf of track refit
   float chi2{-1};    // Chi2
-  int ndf;           // ndf
+  int ndf{-1};       // ndf
   ClassDefNV(FitInfo, 1)
 };
 

Detectors/Upgrades/ITS3/alignment/src/AlignmentSensors.cxx

@@ -10,6 +10,7 @@
 // or submit itself to any jurisdiction.
 
 #include <numbers>
+#include <format>
 
 #include <TGeoManager.h>
 #include <TGeoPhysicalNode.h>

Detectors/Upgrades/ITS3/alignment/src/AlignmentSpec.cxx

@@ -386,7 +386,10 @@ void AlignmentSpec::process()
               if (mOutOpt[OutputOpt::MilleData]) {
                 gblTrajSlot.push_back(traj);
               }
-              FitInfo fit{.ndf = ndf, .chi2 = (float)chi2, .chi2Ndf = (float)chi2 / (float)ndf};
+              FitInfo fit;
+              fit.ndf = ndf;
+              fit.chi2 = (float)chi2;
+              fit.chi2Ndf = (float)chi2 / (float)ndf;
               resTrack.gblFit = fit;
             }
           } else {

Detectors/Upgrades/ITS3/study/macros/PlotMisalignment.C

@@ -14,11 +14,24 @@
 #include <TF1.h>
 #include <TH1F.h>
 #include <TH2F.h>
+#include <TProfile2D.h>
 #include <TCanvas.h>
 #include <TTree.h>
+#include <TStyle.h>
 #endif
 
-void plotTreeVsX(TFile* f, const char* treeName, const char* xVar, const char* xTitle, int nBinsX, float xMin, float xMax)
+TString makeSel(int lay, const char* extraSel)
+{
+  TString sel = Form("lay==%d", lay);
+  if (extraSel && extraSel[0]) {
+    sel += Form(" && %s", extraSel);
+  }
+  return sel;
+}
+
+void plotTreeVsX(TFile* f, const char* treeName, const char* xVar, const char* xTitle,
+                 int nBinsX, float xMin, float xMax,
+                 const char* tag = "", const char* extraSel = "")
 {
   auto res = f->Get<TTree>(treeName);
   const int nVar = 2;
@@ -27,7 +40,7 @@ void plotTreeVsX(TFile* f, const char* treeName, const char* xVar, const char* x
 
   TCanvas* canvs[nVar];
   for (int iv = 0; iv < nVar; iv++) {
-    canvs[iv] = new TCanvas(Form("%s_%s_vs_%s", treeName, vars[iv], xVar), Form("%s vs %s", vars[iv], xVar), 800, 1600);
+    canvs[iv] = new TCanvas(Form("%s_%s_vs_%s%s", treeName, vars[iv], xVar, tag), Form("%s vs %s %s", vars[iv], xVar, tag), 800, 1600);
     canvs[iv]->Divide(2, 4);
   }
 
@@ -37,16 +50,16 @@ void plotTreeVsX(TFile* f, const char* treeName, const char* xVar, const char* x
       canvs[iv]->cd(lay + 2);
       gPad->SetRightMargin(0.13);
 
-      TString hname = Form("h_%s_%s_lay%d", vars[iv], xVar, lay + 1);
+      TString hname = Form("h_%s_%s%s_lay%d", vars[iv], xVar, tag, lay + 1);
       TString expr = Form("%s*10000:%s>>%s(%d,%f,%f,100,-100,100)", vars[iv], xVar, hname.Data(), nBinsX, xMin, xMax);
-      TString sel = Form("lay==%d", lay);
+      TString sel = makeSel(lay, extraSel);
       res->Draw(expr, sel, "col");
 
       auto* h = (TH2F*)gDirectory->Get(hname);
       if (!h) {
         continue;
       }
-      h->SetTitle(Form("Layer %d ;%s;%s", lay, xTitle, titles[iv]));
+      h->SetTitle(Form("Layer %d %s;%s;%s", lay, tag, xTitle, titles[iv]));
       h->GetZaxis()->SetLabelSize(0.035);
 
       // fit y-slices with gaussian
@@ -69,11 +82,97 @@ void plotTreeVsX(TFile* f, const char* treeName, const char* xVar, const char* x
   }
 }
 
+void plotProfile2D(TFile* f, const char* treeName,
+                   const char* tag = "", const char* extraSel = "")
+{
+  auto res = f->Get<TTree>(treeName);
+  const int nVar = 2;
+  const char* vars[nVar] = {"dY", "dZ"};
+  const char* titles[nVar] = {"#LTd_{Y}#GT (#mum)", "#LTd_{Z}#GT (#mum)"};
+
+  TCanvas* canvs[nVar];
+  for (int iv = 0; iv < nVar; iv++) {
+    canvs[iv] = new TCanvas(Form("%s_%s_prof2d%s", treeName, vars[iv], tag), Form("%s #phi vs #eta %s", vars[iv], tag), 800, 1600);
+    canvs[iv]->Divide(2, 4);
+  }
+
+  for (int iv = 0; iv < nVar; iv++) {
+    canvs[iv]->cd(0);
+    for (int lay = -1; lay <= 6; lay++) {
+      canvs[iv]->cd(lay + 2);
+      gPad->SetRightMargin(0.15);
+
+      TString hname = Form("hp_%s%s_lay%d", vars[iv], tag, lay + 1);
+      TString expr = Form("%s*10000:eta:phi>>%s(50,0,%f,50,-1.,1.)", vars[iv], hname.Data(), 2 * TMath::Pi());
+      TString sel = makeSel(lay, extraSel);
+      res->Draw(expr, sel, "prof colz");
+
+      auto* h = (TProfile2D*)gDirectory->Get(hname);
+      if (!h) {
+        continue;
+      }
+      h->SetTitle(Form("Layer %d %s;#phi (rad);#eta;%s", lay, tag, titles[iv]));
+    }
+    canvs[iv]->SaveAs(Form("%s.png", canvs[iv]->GetName()));
+  }
+}
+
+void plotPulls(TFile* f, const char* treeName,
+               const char* tag = "", const char* extraSel = "")
+{
+  auto res = f->Get<TTree>(treeName);
+  const int nPar = 5;
+  const char* parNames[nPar] = {"Y", "Z", "Snp", "Tgl", "Q2Pt"};
+  // diagonal covariance indices in mC[]: 0, 2, 5, 9, 14
+  const int covIdx[nPar] = {0, 2, 5, 9, 14};
+
+  for (int lay = -1; lay <= 6; lay++) {
+    auto* c = new TCanvas(Form("%s_pulls_lay%d%s", treeName, lay, tag), Form("Pulls layer %d %s", lay, tag), 1200, 800);
+    c->Divide(3, 2);
+    TString sel = makeSel(lay, extraSel);
+
+    for (int ip = 0; ip < nPar; ip++) {
+      c->cd(ip + 1);
+      TString hname = Form("hpull_%s%s_lay%d", parNames[ip], tag, lay + 1);
+      TString expr = Form("(trk.mP[%d]-mcTrk.mP[%d])/sqrt(trk.mC[%d])>>%s(100,-5,5)", ip, ip, covIdx[ip], hname.Data());
+      res->Draw(expr, sel);
+
+      auto* h = (TH1F*)gDirectory->Get(hname);
+      if (!h) {
+        continue;
+      }
+      h->SetTitle(Form("Layer %d %s;pull_{%s};counts", lay, tag, parNames[ip]));
+      h->Fit("gaus", "Q");
+    }
+    c->SaveAs(Form("%s.png", c->GetName()));
+  }
+}
+
 void PlotMisalignment(const char* fname = "its3TrackStudy.root")
 {
   auto f = TFile::Open(fname);
+
+  const int nPtBins = 5;
+  const float ptEdges[nPtBins + 1] = {0., 0.3, 0.8, 2., 5., 10.};
+
   for (const char* tree : {"idealRes", "misRes"}) {
+    // integrated plots
     plotTreeVsX(f, tree, "phi", "#phi (rad)", 100, 0, 2 * TMath::Pi());
     plotTreeVsX(f, tree, "eta", "#eta", 100, -1., 1.);
+    plotProfile2D(f, tree);
+    plotPulls(f, tree);
+
+    // pT-binned plots
+    for (int ipt = 0; ipt < nPtBins; ipt++) {
+      TString tag = Form("_pt%.0f_%.0f", ptEdges[ipt] * 10, ptEdges[ipt + 1] * 10);
+      TString ptSel = Form("trk.getPt()>=%.2f&&trk.getPt()<%.2f", ptEdges[ipt], ptEdges[ipt + 1]);
+      TString ptLabel = Form(" (%.1f<p_{T}<%.1f)", ptEdges[ipt], ptEdges[ipt + 1]);
+      TString tagLabel = tag + ptLabel;
+
+      plotTreeVsX(f, tree, "phi", "#phi (rad)", 100, 0, 2 * TMath::Pi(), tag.Data(), ptSel.Data());
+      plotTreeVsX(f, tree, "eta", "#eta", 100, -1., 1., tag.Data(), ptSel.Data());
+      plotProfile2D(f, tree, tag.Data(), ptSel.Data());
+      plotPulls(f, tree, tag.Data(), ptSel.Data());
+    }
   }
 }

Detectors/Upgrades/ITS3/study/src/TrackingStudy.cxx

@@ -1255,12 +1255,12 @@ void TrackingStudySpec::doMisalignmentStudy()
       // propagate MC track to cluster's tracking frame to get true slopes
       auto mcAtCl = mcPar;
       if (!mcAtCl.rotate(orig.alpha) || !prop->PropagateToXBxByBz(mcAtCl, orig.getX())) {
-        clArrMis[1 + iLay] = nullptr; // can't compute slopes → drop cluster
+        clArrMis[1 + iLay] = nullptr; // can't compute slopes -> drop cluster
         continue;
       }
       const float snp = mcAtCl.getSnp();
       const float tgl = mcAtCl.getTgl();
-      const float csci = 1.f / std::sqrt(1.f - (snp * snp)); // 1/cos(phi_local)
+      const float csci = 1.f / std::sqrt(1.f - (snp * snp));
       const float dydx = snp * csci;
       const float dzdx = tgl * csci;
       const float dy = dydx * static_cast<float>(h);