GPU TPC Clusterizer: Fix out of bounds access

davidrohr · davidrohr · commit 9db4f84856c8 · 2026-04-23T10:19:38.000+02:00
diff --git a/GPU/GPUTracking/TPCClusterFinder/GPUTPCCFCheckPadBaseline.cxx b/GPU/GPUTracking/TPCClusterFinder/GPUTPCCFCheckPadBaseline.cxx
@@ -108,7 +108,7 @@ GPUd() void GPUTPCCFCheckPadBaseline::CheckBaselineCPU(int32_t nBlocks, int32_t
   CfChargePos basePos(iBlock * PadsPerCacheline, 0);
 
   constexpr GPUTPCGeometry geo;
-  if (basePos.pad() >= geo.NPads(basePos.row())) {
+  if (basePos.row() >= geo.NROWS || basePos.pad() >= geo.NPads(basePos.row())) {
     return;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,7 @@ GPUd() void GPUTPCCFCheckPadBaseline::CheckBaselineCPU(int32_t nBlocks, int32_t`
`108`	`108`	`CfChargePos basePos(iBlock * PadsPerCacheline, 0);`
`109`	`109`
`110`	`110`	`constexpr GPUTPCGeometry geo;`
`111`		`- if (basePos.pad() >= geo.NPads(basePos.row())) {`
	`111`	`+ if (basePos.row() >= geo.NROWS \|\| basePos.pad() >= geo.NPads(basePos.row())) {`
`112`	`112`	`return;`
`113`	`113`	`}`
`114`	`114`